Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to Refactor code in classes #7

Closed
sguergachi opened this issue Oct 6, 2012 · 2 comments
Closed

Need to Refactor code in classes #7

sguergachi opened this issue Oct 6, 2012 · 2 comments
Assignees
Milestone

Comments

@sguergachi
Copy link
Owner

Go through each class and refactor/clean up the code as much as possible.

Needs to follow Java Conventions.
Needs to flow in a logical fashion.
Needs to remove any repetition
Needs to provide proper naming for variables

@sguergachi
Copy link
Owner Author

Inside a UI class the following objects will always be there

  • The canvas aka. the AuroraCoreUI => coreUI
  • The Handler => handler
  • The Logic => logic

Outside of the class it should be called appropriately

DashboardUI => dashboardUI
DashboardHandler => dashboardHandler
DashboardLogic => dashboardLogic

Parameters values should use the exact spelling of the class except with lowercase capitalization

public searchRefocusListener(GameLibraryUI gameLibraryUI) {
 this.libraryUI = gameLibraryUI;
}

sguergachi added a commit that referenced this issue Oct 23, 2012
sguergachi added a commit that referenced this issue Oct 23, 2012
-Moved random game generator in Dashboard UI to Logic
-Renamed all DashboardUI size fields and getters and setters to convention
-More refactoring of loadUI and buildUI in DashboardUI
sguergachi added a commit that referenced this issue Oct 31, 2012
- Cleaned DashboardLogic commenting
- Refactored all variables for AuroraCoreUI
- Removed unnecessarily commented stuff in AuroraCoreUI
- Added some comments to varibles of AuroraCoreUI
- Added CONTRIBUTING markup doc for coding style documentation
@ghost ghost assigned camachado Nov 1, 2012
sguergachi added a commit that referenced this issue Nov 1, 2012
-AuroraApp commented and refactored
- Implemented new AuroraScreenHandler and AuroraScreenLogic to classes
- some cleaning here and there
- added more stuff to CONTRIBUTING.md
sguergachi added a commit that referenced this issue Nov 5, 2012
@sguergachi
Copy link
Owner Author

Going to close this, from now on as we edit or create any code we must take time to make it clean and well managed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants