設定ファイルロード処理の整理と初期ロード、WPFのファイルダイアログ初期パス記憶 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add last loaded file.
Add file dialog saves last directory.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
・Unity側の設定ファイル読み込み処理を分割・整理しました
・Unity側の設定ファイル読み込み・書き込み時に「前回読み込んだ設定ファイルパス」として記録するようにしました
・Unity側の起動時に、「前回読み込んだ設定ファイルパス」から自動ロードするようにしました
・共通設定ファイルcommon.jsonを追加
・WPF側の各ファイルダイアログの成功時パスを保存、次回の初期パスとして読み込むようにしました
・共通設定ファイルcommonWPF.jsonを追加
コードの変更のみですが、変更の規模と影響範囲が大きいため詳細なレビューをお願いします。
特に
・common.json, commonWPF.jsonの生成位置が想定通りか
・LoadCommonSettings()の例外処理はこれでよいか
ご確認ください。