Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Able to Select Video Quality when Downloading #3

Closed
NevGi-cpu opened this issue Sep 6, 2021 · 37 comments
Closed

Comments

@NevGi-cpu
Copy link

I always download animes in 480p. Because of not having enough storage on my pc. I tried many other scripts like anime-dl and others available on Github. Most of them are outdated and don't work on the websites they tell it will. And even if it works I can't download the videos of my choosing quality.

@NevGi-cpu NevGi-cpu changed the title Able to Select Video Quality when Downloading [Feature Request] Able to Select Video Quality when Downloading Sep 6, 2021
@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 6, 2021

Hello, thank you for your suggestion! I'll work on that after finishing the feature that I will be soon finished (removing the 1 to 99 episodes limit).

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

I always download animes in 480p. Because of not having enough storage on my pc. I tried many other scripts like anime-dl and others available on Github. Most of them are outdated and don't work on the websites they tell it will. And even if it works I can't download the videos of my choosing quality.

Hi! I added the feature that will let you choose the episode quality if you're interested on trying it out you can find it here https://github.com/sh1nobuu/BitAnime/tree/feature/dynamic-episode-quality (Not yet optimized. The optimize version will be out tom.) Thanks!

@NevGi-cpu
Copy link
Author

Yes, I'm very much looking forward to trying it. But, I just have to ask will you be maintaining this project in the future too. Since there is so many projects much like this which was good at first but after some time it was left stagnant.

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

Yes, I'm very much looking forward to trying it. But, I just have to ask will you be maintaining this project in the future too. Since there is so many projects much like this which was good at first but after some time it was left stagnant.

Yes, I'm planning on maintaining this script since I use this script a lot too so you don't need to worry about it being outdated.

@NevGi-cpu
Copy link
Author

Hey i can't use git clone to install bitanime and I also can't install requirements using pip install commands you gave

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

Hey i can't use git clone to install bitanime and I also can't install requirements using pip install commands you gave

Can you paste here the error?

@NevGi-cpu
Copy link
Author

#For Bitanime :
PS C:\Windows\system32> git clone https://github.com/sh1nobuu/BitAnime.git
Error:
git : The term 'git' is not recognized as the name of a cmdlet,
function, script file, or operable program. Check the spelling
of the name, or if a path was included, verify that the path is
correct and try again.
At line:1 char:1

#For Requirements:
PS C:\Windows\system32> pip install -r requirements.txt
Error:
ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt'

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

#For Bitanime :
PS C:\Windows\system32> git clone https://github.com/sh1nobuu/BitAnime.git
Error:
git : The term 'git' is not recognized as the name of a cmdlet,
function, script file, or operable program. Check the spelling
of the name, or if a path was included, verify that the path is
correct and try again.
At line:1 char:1

#For Requirements:
PS C:\Windows\system32> pip install -r requirements.txt
Error:
ERROR: Could not open requirements file: [Errno 2] No such file or directory: 'requirements.txt'

Are you sure you have git install in your pc? You can't install requirements txt if you can't clone the file. An already way to download it is download the zip version.

@NevGi-cpu
Copy link
Author

yes i have installed git using choco.
image

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

yes i have installed git using choco.
image

Have you tried cloning other repo? because from what i can see your system can't recognized git as a command

@NevGi-cpu
Copy link
Author

Seems like I needed to refresh the env now i cloned repo but pip still not working
image

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

Seems like I needed to refresh the env now i cloned repo but pip still not working
image

after cloning the repo you need to cd to the BitAnime folder

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

And if you want to use the script with dynamic script you need to clone the feature/dynamic-episode-quality branch

@NevGi-cpu
Copy link
Author

How do i do that? I tried this:
image

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

How do i do that? I tried this:
image

if you want to clone a specific branch you can follow this command:
"git clone -b feature/dynamic-episode-quality --single-branch https://github.com/sh1nobuu/BitAnime.git"
after cloning the repo cd to the folder
cd BitAnime then "pip install -r requirements.txt"

@NevGi-cpu
Copy link
Author

image

Already installed requirements

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

image

Already installed requirements

The BitAnime folder already exist in your system try deleting it and then run the command again.

@NevGi-cpu
Copy link
Author

image
Now is everything ready? Do I just download and run bitanime.exe or can I run it through PowerShell. How to choose video quality when downloading

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

image
Now is everything ready? Do I just download and run bitanime.exe or can I run it through PowerShell. How to choose video quality when downloading

image
for the quality, you have 4 option: 1: 360p, 2: 480p, 3: 720p, 4: 1080p.

@NevGi-cpu
Copy link
Author

Download not starting
image

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

Download not starting
image

wait for it the site is quite slow to respond therefore the downloading is slow

@NevGi-cpu
Copy link
Author

There was a Vinland Saga folder created and 5 eps downloaded but their size was 60mb and only the first 5min part of the video was playable.

@NevGi-cpu
Copy link
Author

It already closed the .exe after that i found above

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

It already closed the .exe after that i found above

seems like the code is broken let me check

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

I'll mention you after I'm done patching it.

@NevGi-cpu
Copy link
Author

Ok

@NevGi-cpu
Copy link
Author

Just so you don't misunderstand. I closed the .exe myself. And after that i found the anime folder.

@NevGi-cpu
Copy link
Author

I tried again and yes although the progress bar isn't moving the size of episode is increasing I think it's working.

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 9, 2021

I tried again and yes although the progress bar isn't moving the size of episode is increasing I think it's working.

Thanks for the info man seems like the site itself is at fault, I'm having a hard time downloading an episode with a 360P quality

@NevGi-cpu
Copy link
Author

The download is working.
image
I want to change the default dir where the anime is downloaded. How can I do it

@sh1nobuu
Copy link
Owner

The download is working.
image
I want to change the default dir where the anime is downloaded. How can I do it
You can do that by modifying the code in bitanime.py

@sh1nobuu
Copy link
Owner

sh1nobuu commented Sep 10, 2021

The download is working.
image
I want to change the default dir where the anime is downloaded. How can I do it

"""
Create a download folder for the anime
"""
folder = os.path.join(insert-your-path-here , title)
if not os.path.exists(folder):
os.mkdir(folder)

@NevGi-cpu
Copy link
Author

Thanks for everything. And another thing I noticed when I downloaded 2 or 3 720p anime is that some episodes (1 or 2 eps) were in lower-quality like 360p.

@sh1nobuu
Copy link
Owner

Thanks for everything. And another thing I noticed when I downloaded 2 or 3 720p anime is that some episodes (1 or 2 eps) were in lower-quality like 360p.

Glad to help! Older anime don't have an HD version therefore the script will download what's available

@NevGi-cpu
Copy link
Author

I mean i was able to download 720p quality from gogoanime.pe web though and the anime was for Vinland saga, Majo no tabitabi, gleipnir all dubbed versions of 2021 animes

@sh1nobuu
Copy link
Owner

I mean i was able to download 720p quality from gogoanime.pe web though and the anime was for Vinland saga, Majo no tabitabi, gleipnir all dubbed versions of 2021 animes

I see thanks for the feedback I'll look into that!

@sh1nobuu
Copy link
Owner

Updated version of the script is already in the master branch. I will now close this issue.

sh1nobuu added a commit that referenced this issue Dec 28, 2021
…to download as the moment. Gogo Server 2 (server #3) is still broken still finding a way to bypass error 403.
sh1nobuu added a commit that referenced this issue Dec 28, 2021
…to download as the moment. Gogo Server 2 (server #3) is still broken still finding a way to bypass error 403.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants