Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add() in RedisCache without a timeout #218

Merged
merged 1 commit into from Feb 17, 2021
Merged

Fix add() in RedisCache without a timeout #218

merged 1 commit into from Feb 17, 2021

Conversation

ThiefMaster
Copy link
Contributor

When there is no timeout, this resulted in the key expiring immediately after setting it, instead of not having an expiry at all.

@ThiefMaster
Fix add() in RedisCache without a timeout
8560521 
When there is no timeout, this resulted in the key expiring immediately
after setting it, instead of not having an expiry at all.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 79.279% when pulling 8560521 on ThiefMaster:patch-1 into f1899bc on sh4nks:master.

@sh4nks sh4nks merged commit b5fa578 into pallets-eco:master Feb 17, 2021
@sh4nks
Copy link
Collaborator

sh4nks commented Feb 17, 2021

Thanks!

@ThiefMaster ThiefMaster deleted the patch-1 branch February 17, 2021 12:45
This was referenced Mar 18, 2021
Closed
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ThiefMaster @coveralls @sh4nks