Move cache factory functionality into the cache backend classes. #219
Conversation
| "is deprecated. Use the a full path to backend classes " | ||
| "directly.", | ||
| category=DeprecationWarning) | ||
| import_me = type(self).__module__ + '.backends.' + import_me |
There was a problem hiding this comment.
type(self).__module__ is breaking any application that subclasses this class since it will then resolve to the module where the subclass is. So I think this should remain as a hardcoded 'flask_caching.backends.' + import_me
There was a problem hiding this comment.
This line only runs if the cache backend you specify in your config (in CACHE_TYPE) doesn’t contain a dot (see line 218). If you define your own backend, it will be of the form your_package.your_module.YourClass, so import_me won’t be mangled for you.
There was a problem hiding this comment.
i was more thinking about the built-in cache types. CACHE_TYPE = 'null' for example. Why would I ever want that to resolve to something different than the built-in one?
There was a problem hiding this comment.
In that case, null gets expanded to flask_caching.backends.null; self.module is always flask_caching in this context; itʼs written this way so even if we rename the whole module, we donʼt have to modify it here.
There was a problem hiding this comment.
It isn't if you subclass the Caching class in your own module. Then it resolves to that one :/
There was a problem hiding this comment.
Ah, so thatʼs what you meant! Sorry for not getting it earlier.
Yes, you are right. I didnʼt consider that when writing the code because i couldnʼt imagine a use case for that. Unless you want to submit a fix, iʼll look into it later this week.
This is a partial solution to #213