Spinner Not Stopping on max value

[stevensoftwaredev]

My spinner will not stop on max amount. It goes 2 steps above every time if you just hold it down. Once you click back on it goes to max and then starts down if you pressing down. This happens to all the spinners I have on the page also.

[shaack]

Which Browser and Operating System?

[shaack]

Ok, I see it on the Demo page with Firefox.

[stevensoftwaredev]

im pulling it up with notepad ++ on my computer in chrome. I was testing it before i add it to a product designer ui. It looks great in any size screen with chromes developer tools that ive used by the way.

…

On Wed, Apr 25, 2018 at 10:55 AM, Stefan Haack ***@***.***> wrote: Ok, I see it on the Demo page with Firefox. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AP3lS_FV8kczGcHdQu_To4IOurzUXVSlks5tsI5_gaJpZM4TjhU2> .

[shaack]

Thanks for reporting, it should be fixed now. => V 1.3.22

[stevensoftwaredev]

Sorry to bother you. You fixed the issue with the number going over by 2 but i had a question. I would like to make it so it would display feet and inches together. example 5 ' 7". I know the function to change the amount to feet and inches individually and add together. Here is a jsfiddle i have using jquery spinner : https://jsfiddle.net/steven27030/uk6d1up3/ . Is there a way to grab the value and do this with your plugin?

[shaack]

This would be not trivial, because inches is in 12er system, not decimal. It is possible but difficult. One must rethink the whole code-design of the spinner to enable feet and inches, because the value is stored as float and all calculations are done in decimal system for now.

[stevensoftwaredev]

I changed the plugin you did on the my version to do feet and inches. I put the code on jsfiddle in case you wanted it for your plugin. I put notes on what i changed. <script async src="//jsfiddle.net/steven27030/bkmyw6uj/embed/"></script> again thank you.

…

On Thu, Apr 26, 2018 at 7:39 PM, Stefan Haack ***@***.***> wrote: This would be not trivial, because inches is in 12er system, not decimal. It is possible but difficult. One must rethink the whole code-design of the spinner to enable feet and inches, because the value is stored as float and all calculations are done in decimal system for now. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AP3lS6NJ3SDb_H7JhB__j2MqDr7Muo8Kks5tslq7gaJpZM4TjhU2> .

[shaack]

Ok, nice. But... the code was published under MIT License. https://github.com/shaack/bootstrap-input-spinner/blob/master/LICENSE Please, read this license. At this moment your fiddle is a violation, because you must include the copyright "Copyright (c) 2018 Stefan Haack - http://shaack.com". Also, if you use this code at a customers project. You can make this process easier, if you just fork my project here in GitHub and code your changes there and keep the whole package, with license, intact. Thanks Stefan

[shaack]

...for me, it would be also OK, if you just put a link in the JS of your fiddle as reference to the original here: https://github.com/shaack/bootstrap-input-spinner/

[stevensoftwaredev]

i forked yours and changed it. Im a rookie at this so hopefully i did it right.

…

On Sat, Apr 28, 2018 at 4:24 AM, Stefan Haack ***@***.***> wrote: ...for me, it would be also OK, if you just put in link in your fiddle as reference to the original here: https://github.com/shaack/ bootstrap-input-spinner/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AP3lS9bJPDvwzXmaCeJ22Sof5jqJTz4xks5ttCckgaJpZM4TjhU2> .

[shaack]

Hi, thanks. Looks good. I am also just in it (GitHub) since 1/2 year, so I am also not really a GitHub pro. For information purpose, I think it would be a good idea, to add a comment in the forked sourcecode. Something like:

/**
 * Author: Stefan Haack (https://github.com/shaack)
 * License: MIT, see file 'LICENSE'
 * Modified by stevensoftwaredev (or your real name) to display feet and inches. 
 */

And maybe also in the README.md, so everyone knows how your forked spinner works. Maybe there are some people out there who also need a feet and inches input.
Thanks, have fun,
Stefan