Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap 4 vertical alignment #28

Closed
jrichview opened this issue Mar 11, 2019 · 6 comments
Closed

Bootstrap 4 vertical alignment #28

jrichview opened this issue Mar 11, 2019 · 6 comments

Comments

@jrichview
Copy link

I'm using bootstrap 4 and displaying this in an html table cell. In the attached image you will note that the vertical alignment is different from the other controls in the table row. The other inputs around it are all "form-control-sm" and I have initialized as follows:

$("input[type='number']").inputSpinner({
groupClass: "input-group-sm",
buttonsWidth: "0.5rem"
});

Capture

@shaack
Copy link
Owner

shaack commented Mar 12, 2019 via email

@jrichview
Copy link
Author

Sure. This is just a mock-up proof of concept, but it's an an MVC app built on ASP.NET core. I published it out to a free Azure App Service which is pretty limited, but should be adequate for this purpose: https://apalacheectrpoc20190312090704.azurewebsites.net/

@shaack
Copy link
Owner

shaack commented Mar 12, 2019 via email

@jrichview
Copy link
Author

Hm. Quite right. Unexpected though. I originally laid out this screen without any 3rd party controls, just what Bootstrap provides. So that class was there originally before I included your lib. Not using it might be worth a mention in the documentation. Thanks for the assist!

@shaack
Copy link
Owner

shaack commented Mar 12, 2019

Yes, maybe it would make sense to automatically converted "form-control-xx" to "input-group-xx" in the resulting element. And it should be documented. Thanks again for reporting.

@shaack shaack reopened this Mar 12, 2019
@shaack
Copy link
Owner

shaack commented Mar 15, 2019

Okay, sizing with version 1.11 now works out of the box. c73ad75
If the original elements class is set to form-control-sm of form-control-lg the class of the resulting input-group is dynamically set to input-group-sm or input-group-lg.

No need to set the groupClass class in the configuration anymore for sizing.

@shaack shaack closed this as completed Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants