Fix inconsistent next and previous pointers #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #20.
Overview
History.traverse()
to only setprevious
andnext
pointers if move doesn't already have pointers set.This fixes (what I believe to be) a bug in traverse where a move in the main line will get its
next
property set to the first move of an alternate line rather than the next move in its own line.In general, it seems the correct behavior ought to be that every move in
move.variation
should satisfyIf one of those moves has variations branching off it, that shouldn't matter to that move's
previous
andnext
pointers.