Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.0 #1640

Open
nicolasdanelon opened this issue Nov 12, 2020 · 7 comments
Open

Version 1.0.0 #1640

nicolasdanelon opened this issue Nov 12, 2020 · 7 comments

Comments

@nicolasdanelon
Copy link

Hello guys,
I saw lot of big changes and improvements here.

  • remove old versions of php
  • support for php 7.4 and 8
  • mayor cleanup for index.php file
  • functionalities moved to packages

but we still keeping the 0.1X.X version code name. why? you guys have added tons of code, make big refactors and add many many mayor changes. when are you planning to release the 1.0.0 version?

I think you guys are doing the same thing that facebook did with react.

Ok, that's my little question, hope to read you soon guys. Thanks!

@ArthurHoaro
Copy link
Member

ArthurHoaro commented Nov 13, 2020

That's a good question. I'm not exactly sure how or when we should proceed, but I'd like to see 4 major changes before moving to 1.0.0 to limit future breaking changes:

Maybe we could focus on those and decide that our new major version will 1.0.0.

@nodiscc
Copy link
Member

nodiscc commented Nov 13, 2020

@nicolasdanelon suggestions of what do before 1.0.0 are welcome, it would be preferable not to change interfaces too much after the release.

@nicolasdanelon
Copy link
Author

@nodiscc no more suggestions, thanks for the space.

One thing I've notice when updated one old and lost shaarli.. can we add plugins with composer? otherwise the plugin management (at least markdown and code_coloration) is not easy to do. I can create a new issue for this one. let me know if you need more info or has this already detected.

thanks again!

@immanuelfodor
Copy link

I'm not really fond of the PHP composer idea as I'm not a PHP developer but I really love easily copying files here and there 😃 It seems my previous suggestion of a custom plugin folder got many upvotes in the past year, maybe it could solve your problem, too: #1372 (comment)

@nicolasdanelon
Copy link
Author

@immanuelfodor thanks for your help, that link really help BUT if some dev changes the folder structure I would have a problem with my setup. If everybody works with composer (actually php) standars that won't be able to happen. ever.
@immanuelfodor what do you think about moving shaarli from json files to sqlite database?

nonetheless that docker file really help, thanks!

@immanuelfodor
Copy link

Plugins: Well, as my composer knowledge is only about composer install, I thought moving all Shaarli plugins to composer would require additional time investment from contributors and users, that's for sure. My imagined persona of a Shaarli user is a "privacy entusiast, hobby DIY tinker, docker-compose up runner", so anything harder should be guided with docs. For both the existing plugin ecosystem composer-ification (dev guide), and both the plugin installation (user guide). This is much more complex to execute than having a standard folder for local plugins, and as Python says, simple is better than complex, complex is better than complicated, and so on. 😃 The local folder could even override the included plugins to support customization, if this is needed, for example, if a code_coloration folder exists in the local folder, then it's included in Shaarli instead of the bundled.

RDBMS: I've added some comments about the topic, starting from here: #953 (comment) Arthur's last comment is relieving about intending to supporting more DB systems. I'd love to have at least one from the Maria/My/PG triplet.

@nodiscc
Copy link
Member

nodiscc commented Nov 25, 2020

regarding composer-based plugin install vs. plugins-local/ directory-based install, the directory based system is definitely better as many environments might not have composer available (and more generally build/dev utilities not strictly necessary to execution of the program should not be present on production environments - or anything that faces the Internet). So regardless of users technical level/interest, just moving files around the filesystem is the right* thing to do most of the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants