Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Read later" bookmarklet #143

Closed
nodiscc opened this issue Mar 5, 2015 · 15 comments · Fixed by #1727
Closed

Add a "Read later" bookmarklet #143

nodiscc opened this issue Mar 5, 2015 · 15 comments · Fixed by #1727
Assignees
Labels
Milestone

Comments

@nodiscc
Copy link
Member

nodiscc commented Mar 5, 2015

Reported by @sebsauvage at sebsauvage#7:

This button would:

Immediately record the current page link in Shaarli (no dialog).
The link would be private.
This link would bear a special tag (such as TLDR).

This way, you could keep link to read later at the single click of a button.

Does this button require a visual feedback ? (like an in-page CSS popup ?)

@e2jk
Copy link

e2jk commented Mar 5, 2015

Yeah, I would gladly stop using readability.com for my own self-hosted solution! (although it wouldn't do the "keep only the content" part that is also pretty nice...)

@nodiscc nodiscc self-assigned this Mar 6, 2015
@nodiscc nodiscc modified the milestone: 1.0 Mar 13, 2015
@nodiscc nodiscc modified the milestones: 1.1, 1.0 Mar 13, 2015
@kalvn
Copy link

kalvn commented Mar 18, 2015

I think it would require indeed a visual feedback (like a gray or semi-transparent background to show that it hasn't been reviewed yet). But most of all it would require a specific page to show all "to-read-later" links. And maybe a way to quickly review them so they are added with regular links.

@nodiscc
Copy link
Member Author

nodiscc commented Mar 18, 2015

In the first time I think we can:

  • Add a bookmarklet ✚Read later to the tools page.
  • When clicked, this bookmarklet opens a small Shaarli window, saves the link as private with a specific tag (let's hardcode readlater first), displays Link saved in your read later list!, and autocloses after 2s.
  • Explain how to access the readlater list in the tools page (basically just a link to ?searchtags=readlater)

Sounds good?

Edit: and for what @e2jk suggested, you can already self-host wallabag which is a read-it-later service with improved readability features. It can fetch RSS feeds items automatically, just point it at https://my.shaarly.url/?do=rss&searchtags=readlater

@nodiscc
Copy link
Member Author

nodiscc commented Apr 6, 2015

The pull request #192 works but I'd like to move this to a plugin. See https://github.com/nodiscc/Shaarli/blob/readlater-bookmarklet/tpl/TODO.md. Blocked by #14

@nodiscc
Copy link
Member Author

nodiscc commented Jul 26, 2015

Feedback needed :)

  • Should we add a "Read Later" bookmarklet by default on the tools page (saves a link as private, tagged readlater)? I don't mind if there is a confirmation dialog. In this case there needs to be a button somewhere to quickly access links tagged readlater.
  • Should we go the "plugin" way I suggested (see https://github.com/nodiscc/Shaarli/blob/readlater-bookmarklet/tpl/TODO.md#the-plugin-itself)? This may be over engineered, but it allows creating multiple lists with different roles+quick access buttons.

@nodiscc
Copy link
Member Author

nodiscc commented Jul 26, 2015

Note that a "true" read-it-later solution would be available with the proposed wallabag plugin

@nodiscc nodiscc removed their assignment Jul 26, 2015
@nicolasdanelon
Copy link

Please add as plugin.. There's a lot of php apps for read it later :) its a nice plugin for shaarli

@virtualtam virtualtam modified the milestones: 1.1, 0.6.0 Jul 30, 2015
@ArthurHoaro
Copy link
Member

It can be a plugin. If it's only another bookmarklet, might not be necessary though.

@nicolasdanelon
Copy link

I think that too. it might not be necessary

@virtualtam
Copy link
Member

+1 for having bookmarklets as plugins :)

@ArthurHoaro ArthurHoaro added this to the 0.10.4 milestone Aug 11, 2018
@virtualtam virtualtam modified the milestones: 0.10.4, 0.11.0 Feb 23, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.0, 0.11.1 Jul 27, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.1, 0.11.2 Aug 7, 2019
@Quentin-ctrL
Copy link

In the plugin list, I can't find a "Read later" plugin.
https://shaarli.readthedocs.io/en/master/Community-&-Related-software/
Is there something new ?

@ArthurHoaro
Copy link
Member

This issue is still open, so it does not exists yet.

@ArthurHoaro ArthurHoaro modified the milestones: 0.12.0, 0.12.1 Sep 3, 2020
@ArthurHoaro ArthurHoaro modified the milestones: 0.12.1, 0.12.2 Oct 27, 2020
@ArthurHoaro ArthurHoaro self-assigned this Oct 27, 2020
@ArthurHoaro
Copy link
Member

I have thought about this, and I think that we should add a full featured core plugin « Read it later ». A bunch of bookmark manager or related software have this, as a flag visible in the UI. I have started to work on a proof of concept. So the idea would be:

  • add the bookmarklet as mentioned by this issue
  • add a button on linklist to mark as read/unread
  • add a visual helper to easily see unread links
  • add two filter to display read and unread bookmarks

PoC UI idea (subject to change):

Any feedback is welcome.

@nodiscc
Copy link
Member Author

nodiscc commented Oct 30, 2020

Where would you store the read/unread status? Another field in the datastore entry? Special unread tag?

@ArthurHoaro
Copy link
Member

I recently added an additionalContent field in bookmarks. I plan to store the flag in this field, and pass it through formatters (so yes, in the datastore).

ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 14, 2020
  - each route will be prefixed by `/plugin/<plugin_name>`
  - add a new template for plugins rendering
  - add a live example in the demo_plugin

Check out the "Plugin System" documentation for more detail.

Related to shaarli#143
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Nov 15, 2020
  - each route will be prefixed by `/plugin/<plugin_name>`
  - add a new template for plugins rendering
  - add a live example in the demo_plugin

Check out the "Plugin System" documentation for more detail.

Related to shaarli#143
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Jan 20, 2021
A new plugin hook has been added: hook_test_filter_search_entry
This hook allows to filter out bookmark with custom plugin code when a search is performed.

Related to shaarli#143
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Feb 4, 2021
A new plugin hook has been added: hook_test_filter_search_entry
This hook allows to filter out bookmark with custom plugin code when a search is performed.

Related to shaarli#143
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue Apr 3, 2021
Create a new core plugin allowing to mark bookmarks to read them later.
When enabled:

  * checkbox is displayed in editlink view for new bookmarks
  * a plugin setting is available to check it or not it by default
  * in bookmark list:
    * new global filter to display only bookmark flagged as read it
      later
    * for each bookmarks, new action icon to toggle read it later status
    * for each « readitlater » bookmark, red label « To Read » added,
      and red line on the right of the bookmark added (default template)

Fixes shaarli#143

Signed-off-by: ArthurHoaro <arthur@hoa.ro>
ArthurHoaro added a commit to ArthurHoaro/Shaarli that referenced this issue May 13, 2021
Create a new core plugin allowing to mark bookmarks to read them later.
When enabled:

  * checkbox is displayed in editlink view for new bookmarks
  * a plugin setting is available to check it or not it by default
  * in bookmark list:
    * new global filter to display only bookmark flagged as read it
      later
    * for each bookmarks, new action icon to toggle read it later status
    * for each « readitlater » bookmark, red label « To Read » added,
      and red line on the right of the bookmark added (default template)

Fixes shaarli#143

Signed-off-by: ArthurHoaro <arthur@hoa.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants