Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: missing "formatter" setting in JSON config example #1680

Closed
nodiscc opened this issue Jan 10, 2021 · 0 comments · Fixed by #1806
Closed

doc: missing "formatter" setting in JSON config example #1680

nodiscc opened this issue Jan 10, 2021 · 0 comments · Fixed by #1806
Assignees
@nodiscc
Labels
documentation
Milestone
1.0.0

Comments

@nodiscc
Copy link
Member

nodiscc commented Jan 10, 2021

There is a section about Formatter at https://shaarli.readthedocs.io/en/master/Shaarli-configuration/#formatter but the example json configuration does not mention it.

The example json config also has a duplicate general dict.
@nodiscc nodiscc self-assigned this Jan 10, 2021
@nodiscc nodiscc added this to the 1.0.0 milestone Oct 2, 2021
nodiscc added a commit to nodiscc/Shaarli that referenced this issue Oct 10, 2021
@nodiscc
doc: remove duplicate "general" key in example config.php.json
df0ca43 
- ref. shaarli#1680
nodiscc added a commit to nodiscc/Shaarli that referenced this issue Oct 10, 2021
@nodiscc
doc: add "formatter" key to example config.json.php
7ae4b2f 
- fixes shaarli#1680
@nodiscc nodiscc mentioned this issue Oct 10, 2021
Merged
nodiscc added a commit that referenced this issue Dec 17, 2021
@nodiscc
Merge pull request #1806 from nodiscc/doc-fix-example-config-json
aeda845 
doc: add "formatter" setting to example.json.php, remove duplicate "general" key
fixes #1680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nodiscc nodiscc

Labels
documentation
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

doc: add "formatter" setting to example.json.php, remove duplicate "general" key nodiscc/Shaarli
1 participant
@nodiscc