Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Docker images on Pull Requests #1800

Closed
nodiscc opened this issue Sep 11, 2021 · 1 comment · Fixed by #2014
Closed

Build Docker images on Pull Requests #1800

nodiscc opened this issue Sep 11, 2021 · 1 comment · Fixed by #2014
Labels
docker containers & cloud enhancement tools developer tools

Comments

@nodiscc
Copy link
Member

nodiscc commented Sep 11, 2021

Building docker images from each Pull Request would ease testing of the proposed changes. Docker users would only have to set the proper image tag in their deployment script/compose file to start testing a development branch of Shaarli. Images could be stored on the free 500MB container registry attached to the project if we want to separate release/official (hub.docker.com) and development/testing images.

Running these builds/pushing to the registry should probably require maintainer approval (it is probably possible to abuse package/image upload permissions from a malicious PR, depending on how we set it up).

It is also required to properly test changes that affect the Docker image build itself #1789 (review).

Related to #1555 (automatic build/upload to the package registry fro full .zip builds)

@nodiscc nodiscc added enhancement tools developer tools labels Sep 11, 2021
@nodiscc nodiscc self-assigned this Sep 11, 2021
This was referenced Sep 11, 2021
@nodiscc nodiscc added the docker containers & cloud label Sep 11, 2021
@nodiscc nodiscc removed their assignment Oct 2, 2021
@nodiscc nodiscc added this to the backlog to the future milestone Oct 2, 2021
@nodiscc nodiscc self-assigned this Oct 10, 2021
nodiscc added a commit to nodiscc/Shaarli that referenced this issue Aug 19, 2023
- fixes shaarli#1800
- do not push, only check that the image builds correctly
nodiscc added a commit to nodiscc/Shaarli that referenced this issue Aug 19, 2023
- fixes shaarli#1800
- do not push, only check that the image builds correctly
- tag the image as :pr-PR_NUMBER
@nodiscc
Copy link
Member Author

nodiscc commented Aug 19, 2023

PR at #2014

ease testing of the proposed changes

I have left this aspect aside for now, the new workflow only ensures that the image builds without errors, but does not push to the registry. I think pushing images for every PR is not necessary, and would clutter the registry over time - we would have to manually clean it up from time to time.

@nodiscc nodiscc removed their assignment Aug 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker containers & cloud enhancement tools developer tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant