Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add themes management #22

Closed
qwertygc opened this issue Sep 1, 2014 · 6 comments · Fixed by #732
Closed

Add themes management #22

qwertygc opened this issue Sep 1, 2014 · 6 comments · Fixed by #732
Labels
feature template HTML rendering tools developer tools
Milestone

Comments

@qwertygc
Copy link

qwertygc commented Sep 1, 2014

Hello !
It's possible to add a themes managment e.g a folder by theme ? And a variable show the theme.
A other suggestion it's the possibility to translate shaarli.
Regards

@e2jk
Copy link

e2jk commented Sep 1, 2014

Themes is discussed in issue #14, as part of the plugin system.
Translation has been discussed a while ago on Sebsauvage's upstream, see sebsauvage#18.

Next steps according to me: we need to first finalize the transition to the Shaarli organization, and have @sebsauvage validate that, then we can start working on the somewhat more disruptive changes such as the plugin system, and i18n.

@nodiscc nodiscc changed the title Suggests : Add themes managment & I18N Suggests : Add themes managment Oct 15, 2014
@nodiscc nodiscc changed the title Suggests : Add themes managment Add themes management Oct 15, 2014
@nodiscc
Copy link
Member

nodiscc commented Oct 15, 2014

I've edited the issue title to only focus on themes management.
Feel free to reopen a separate issue for I18N

@nodiscc nodiscc self-assigned this Oct 15, 2014
@nodiscc
Copy link
Member

nodiscc commented Nov 6, 2014

TODO:

  • transfer ownership of shaarli-themes to the organization done
  • rename shaarli-themes to themes
  • add a SHAARLI_THEME config variable, defaults to default
    • try to load inc/themes/$SHAARLI_THEME/$SHAARLI_THEME.css
    • if file unreadable or it's set to default, use inc/shaarli.css
  • update and translate doc on theming
    • to install some themes, clone or unpack the themes repository in inc/
    • to manually install a theme, unpack it to it's own directory in inc/themes/ (see naming conventions)

Related:

@alexisju
Copy link

alexisju commented Mar 5, 2015

Why do you consider that a "theme" is just another CSS ? To make AlbinoMouse (http://liens.effingo.be) i had to change many tpl to design really a something different.

It's why i need to maintain another full repository (what is not very convenient).

@nodiscc
Copy link
Member

nodiscc commented Mar 5, 2015

@alexisju Yep! This is why we differentiate between themes and templates (btw albinomouse is very nice)

There is still much work to do about this but users can already:

  • clone the templates repository to eg. templates/ in their Shaarli install
  • set their config variable $GLOBALS['config']['RAINTPL_TPL'] = 'templates/albinomouse/ to use your template + theme

In the future:

There could be a config variable $GLOBALS['config']['CSS_THEME']. This would allow selecting the CSS file in use for the current theme; but we need to standardize that (eg. Shaarli's default is shaarli.css, yours is albinomouse.css and in the hoaro theme it's css/style.css)

But in the long run, I'm not sure we should add theme management. Collecting themes and templates is a good idea, but simply replacing user.css is already nice and doesn't interefer with the update process.

@alexisju
Copy link

alexisju commented Mar 5, 2015

ok, I'll consider this to try to make my templates a bit more compliant to follow future updates from the community fork of shaarli :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature template HTML rendering tools developer tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants