Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests compatibily with PHP 5.3 #250

Closed
ArthurHoaro opened this issue Jun 26, 2015 · 6 comments
Closed

Tests compatibily with PHP 5.3 #250

ArthurHoaro opened this issue Jun 26, 2015 · 6 comments
Labels
feedback needed

Comments

@ArthurHoaro
Copy link
Member

I mentionned in #218 that tests are not compatible with PHP 5.3. I thought it didn't matter because we run test in dev environment. However, if we wan't to keep 5.3 compatibility for Shaarli, and avoid issue like #241, it would be better if we could test it in PHP 5.3.

We could also drop PHP 5.3 compatibility since it's an old and apparently not maintained version.
@nodiscc
Copy link
Member

nodiscc commented Jun 26, 2015

We could also drop PHP 5.3 compatibility

Yes. PHP 5.3 also has a lot of unfixed security vulnerabilities: www.cvedetails.com/version-list/74/128/3/PHP-PHP.html?order=1&trc=265. I'll probably merge #249 as this is a simple fix, but PHP 5.3 should not be a requirement.

Debian has PHP 5.6 in stable and 5.4 in oldstable (https://packages.debian.org/search?keywords=php5)! Should we bump the requirements in the README to PHP 5.4/5.5 ?

This was referenced Jun 26, 2015
Merged
Closed
@virtualtam
Copy link
Member

+1 for having 5.4 as a minimum requirement

@ArthurHoaro
Copy link
Member Author

Should we update checkphpversion() to display an error if PHP version is < 5.4?

@ArthurHoaro ArthurHoaro reopened this Jul 10, 2015
@virtualtam
Copy link
Member

I'd say "yes for now", and take some time to toy with phpenv to see how much work would be needed to keep 5.3 compatibility (did I mention it's a very old version? :p)

virtualtam added a commit to virtualtam/Shaarli that referenced this issue Jul 11, 2015
@virtualtam
PHP: ensure 5.3 compatibility
78cf5bf 
Relates to shaarli#250

Modifications
 - add PHP 5.3 to Travis environments
 - rewrite array declarations: explicitely use array() instead of []
 - move checkPHPVersion to application/Utils.php
 - bump required version from 5.1.0 to 5.3.x

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam virtualtam mentioned this issue Jul 11, 2015
Merged
@virtualtam
Copy link
Member

For now, the sole constraint seems to have to declare arrays by explicitely using array() instead of [].
Before merging #271, I'd like to know if anyone has encountered other issues with 5.3.x versions of PHP...

virtualtam added a commit to virtualtam/Shaarli that referenced this issue Jul 11, 2015
@virtualtam
PHP: ensure 5.3 compatibility
03eae1b 
Relates to shaarli#250

Modifications
 - add PHP 5.3 to Travis environments
 - rewrite array declarations: explicitely use array() instead of []
 - move checkPHPVersion to application/Utils.php
 - move timezone functions to application/TimeZone.php
 - bump required version from 5.1.0 to 5.3.x

TODO
 - TZ code cleanup
 - TZ test coverage

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Jul 11, 2015
@virtualtam
PHP: ensure 5.3 compatibility
7a02c95 
Relates to shaarli#250

Modifications
 - add PHP 5.3 to Travis environments
 - rewrite array declarations: explicitely use array() instead of []
 - move checkPHPVersion to application/Utils.php
 - move timezone functions to application/TimeZone.php
 - improve test coverage
 - bump required version from 5.1.0 to 5.3.x

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Jul 11, 2015
@virtualtam
PHP: ensure 5.3 compatibility
e3b48b3 
Relates to shaarli#250

Modifications
 - add PHP 5.3 to Travis environments
 - rewrite array declarations: explicitely use array() instead of []
 - move checkPHPVersion to application/Utils.php
 - move timezone functions to application/TimeZone.php
 - improve test coverage
 - bump required version from 5.1.0 to 5.3.x

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Jul 12, 2015
@virtualtam
PHP: ensure 5.3 compatibility, refactor timezone utilities
6bc288e 
Relates to shaarli#250

Modifications
 - supported version
   - bump required version from 5.1.0 to 5.3.x
   - update README
   - add PHP 5.3 to Travis environments
 - rewrite array declarations: explicitely use array() instead of []
 - move checkPHPVersion to application/Utils.php
 - move timezone functions to application/TimeZone.php
   - cleanup code
   - improve test coverage

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Jul 12, 2015
@virtualtam
PHP: ensure 5.3 compatibility, refactor timezone utilities
1464542 
Relates to shaarli#250

Modifications
 - supported version
   - bump required version from 5.1.0 to 5.3.x
   - update README
   - add PHP 5.3 to Travis environments
 - rewrite array declarations: explicitely use array() instead of []
 - move checkPHPVersion to application/Utils.php
 - move timezone functions to application/TimeZone.php
   - cleanup code
   - improve test coverage

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Jul 12, 2015
@virtualtam
PHP: ensure 5.3 compatibility, refactor timezone utilities
7ab6c25 
Relates to shaarli#250

Modifications
 - supported version
   - bump required version from 5.1.0 to 5.3.x
   - update README
   - add PHP 5.3 to Travis environments
 - rewrite array declarations: explicitely use array() instead of []
 - move checkPHPVersion to application/Utils.php
 - move timezone functions to application/TimeZone.php
   - cleanup code
   - improve test coverage

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Jul 12, 2015
@virtualtam
PHP: ensure 5.3 compatibility, refactor timezone utilities
12df6c6 
Relates to shaarli#250

Modifications
 - supported version
   - bump required version from 5.1.0 to 5.3.x
   - update README
   - add PHP 5.3 to Travis environments
 - rewrite array declarations: explicitely use array() instead of []
 - move checkPHPVersion to application/Utils.php
 - move timezone functions to application/TimeZone.php
   - cleanup code
   - improve test coverage

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Jul 13, 2015
@virtualtam
PHP: ensure 5.3 compatibility, refactor timezone utilities
d1e2f8e 
Relates to shaarli#250

Modifications
 - supported version
   - bump required version from 5.1.0 to 5.3.x
   - update README
   - add PHP 5.3 to Travis environments
 - rewrite array declarations: explicitely use array() instead of []
 - move checkPHPVersion to application/Utils.php
 - move timezone functions to application/TimeZone.php
   - cleanup code
   - improve test coverage

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@ArthurHoaro
Copy link
Member Author

PR merged.

@ArthurHoaro ArthurHoaro mentioned this issue Apr 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feedback needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@virtualtam @ArthurHoaro @nodiscc