Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't add same tag twice in the searchtags list #50

Closed
nodiscc opened this issue Nov 8, 2014 · 0 comments · Fixed by #60
Closed

don't add same tag twice in the searchtags list #50

nodiscc opened this issue Nov 8, 2014 · 0 comments · Fixed by #60
Labels
bug it's broken!

Comments

@nodiscc
Copy link
Member

nodiscc commented Nov 8, 2014

This was reported at sebsauvage#140

When I'm filtering the posts by a tag, and then, I click on the same tag in the page, it's appended to the searchtags list. Which makes that on this page:
http://cladmi.eu/shaarli/?searchtags=Recettes
I click on the 'Recettes' tag, I get
http://cladmi.eu/shaarli/?searchtags=Recettes+Recettes
and "Nothing found."
I think it would be better to don't add the tag if it's already in the searchtags list.
@nodiscc nodiscc added the bug it's broken! label Nov 8, 2014
@pikzen pikzen mentioned this issue Nov 20, 2014
Merged
nodiscc added a commit that referenced this issue Nov 21, 2014
@nodiscc
Merge pull request #60 from pikzen/master
4ad88dd 
Do not add a tag to the search if it's already being searched for.
 * Fixes #50
 * Fixes sebsauvage#140
@nodiscc nodiscc mentioned this issue Nov 27, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug it's broken!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not add a tag to the search if it's already being searched for pikzen/Shaarli
1 participant
@nodiscc