Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessing private links in RSS feeds without being logged in #845

Open
an-ca opened this issue Apr 7, 2017 · 4 comments
Open

Accessing private links in RSS feeds without being logged in #845

an-ca opened this issue Apr 7, 2017 · 4 comments
Labels
Milestone

Comments

@an-ca
Copy link

an-ca commented Apr 7, 2017

I've created a Shaarli instance recently and it's all going smoothly!

Currently the generated feeds (for instance /?do=rss&searchtags=toread) display private links if the user is currently logged in and public links.

Is there a way to include private links if the user is not logged in?
The first obvious idea that comes to mind would be to use random private keys (/?do=rss&searchtags=toread&key=rfyugbinuyhinjkljhgfbdv).

My use case is to have my Tiny Tiny RSS instance to subscribe to my Shaarli feeds (all my links on Shaarli are private).

Thanks!

@ArthurHoaro
Copy link
Member

Unfortunately, that's not possible yet. It's related to #475 (the thread isn't really relevant).

@ArthurHoaro ArthurHoaro added this to the 0.9.1 milestone Apr 7, 2017
@virtualtam virtualtam modified the milestones: 0.10.0, 0.9.1 Jul 29, 2017
virtualtam added a commit to virtualtam/Shaarli that referenced this issue Sep 28, 2017
Relates to shaarli#845
Relates to shaarli#846
Relates to shaarli#909

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
@virtualtam virtualtam modified the milestones: 0.10.0, 0.10.1 Jan 10, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.1, 0.10.2 Jul 29, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.10.2, 0.10.3, 0.11.0 Aug 11, 2018
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.0, 0.11.1 Jul 27, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.11.1, 0.11.2 Aug 7, 2019
@ArthurHoaro ArthurHoaro modified the milestones: 0.12.0, 0.12.1 Sep 3, 2020
@ArthurHoaro
Copy link
Member

I have an almost working PR ready to share private bookmarks by URL (#475) but I'm slightly torn about this issue:

  • it seems like a huge privacy breach: any service logging the URL's key would have access to all private bookmarks.
  • I don't really understand the use case because it would mean subscribing to your own bookmarks

I'd like to have more opinions about that.

@nodiscc
Copy link
Member

nodiscc commented Oct 17, 2020

it seems like a huge privacy breach: any service logging the URL's key would have access to all private bookmarks.

Yes. The key could be unique to each share. But then comes the problem of how it is generated, stored...

Edit: some tools assume this is fine. For example tt-rss has a feature that generates a private feed from bookmarked items, this feed is only protected by a single secret key in URL parameters. So this might be ok with a proper warning.

I don't really understand the use case because it would mean subscribing to your own bookmarks

Why not?

all my links on Shaarli are private

Then for this specific use case, why not put Shaarli behind HTTP Basic authentication? TT-RSS supports authenticating to feeds in this way. See #802 and #1189 (where you can find a PoC for basic auth in apache, with some problems - overides some default deny directives)

@ArthurHoaro
Copy link
Member

Then for this specific use case, why not put Shaarli behind HTTP Basic authentication?

You actually gave me an idea. It's apparently possible to request an HTTP authentication from PHP. What if we just triggered that to display the private ATOM feed?

For the record, I use FreshRSS which also seems to support HTTP Basic auth.

@nodiscc nodiscc modified the milestones: 0.13.0, 0.14.0 Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants