Fix order of tags with the same number of occurrences #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virtualtam
reviewed
May 29, 2018
application/LinkDB.php
Outdated
| @@ -458,8 +458,10 @@ public function linksCountPerTag($filteringTags = [], $visibility = 'all') | |||
| $tags[$caseMapping[strtolower($tag)]]++; | |||
| } | |||
| } | |||
| // Sort tags by usage (most used tag first) | |||
| arsort($tags); | |||
| $keys = array_keys($tags); | |||
There was a problem hiding this comment.
Would be worth testing and documenting for future reference (e.g. when we drop PHP 5.6 support)
There was a problem hiding this comment.
You're right, this method doesn't seem to be tested.
Before this, linksCountPerTag call without would have ignored visibility parameter
virtualtam
approved these changes
Jun 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1142