Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a warning if links sticky status isn't set #1270

Merged
merged 1 commit into from Feb 24, 2019
Merged

Fix a warning if links sticky status isn't set #1270

merged 1 commit into from Feb 24, 2019

Conversation

ArthurHoaro
Copy link
Member

  • initiate its status to false when the link is created
  • if not defined, initiate its status to false (can happen if the updater hasn't run)

@ArthurHoaro
Fix a warning if links sticky status isn't set
b790f90 
  - initiate its status to false when the link is created
  - if not defined, initiate its status to false (can happen if the updater hasn't run)
@ArthurHoaro ArthurHoaro added bug it's broken! in review labels Feb 9, 2019
@ArthurHoaro ArthurHoaro added this to the 0.10.3 milestone Feb 9, 2019
@ArthurHoaro ArthurHoaro self-assigned this Feb 9, 2019
@virtualtam virtualtam modified the milestones: 0.10.3, 0.11.0 Feb 23, 2019
@ArthurHoaro ArthurHoaro merged commit c21dcc8 into shaarli:master Feb 24, 2019
@ArthurHoaro ArthurHoaro deleted the hotfix/sticky-warning branch February 24, 2019 10:30
@ArthurHoaro ArthurHoaro mentioned this pull request Mar 8, 2019
Closed
virtualtam added a commit that referenced this pull request Apr 15, 2019
@virtualtam
backport: Fix a warning if links sticky status isn't set
1cc5eaf 
- initiate its status to false when the link is created
- if not defined, initiate its status to false (can happen if the updater hasn't run)

This is a backport of #1270

Original author information:

commit b790f90
Author: ArthurHoaro <arthur@hoa.ro>
Date:   Sat Feb 9 14:04:16 2019 +0100

Signed-off-by: VirtualTam <virtualtam@flibidi.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nodiscc nodiscc nodiscc approved these changes

Assignees

@ArthurHoaro ArthurHoaro

Labels
bug it's broken! in review
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArthurHoaro @nodiscc @virtualtam