Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php-json as required PHP module #1379

Merged
merged 2 commits into from
Nov 9, 2019
Merged

Add php-json as required PHP module #1379

merged 2 commits into from
Nov 9, 2019

Conversation

rfolo9li
Copy link

@rfolo9li rfolo9li commented Nov 9, 2019

Without php-json the installation stops with a white screen and the following error:

09-Nov-2019 14:05:46 UTC] PHP Fatal error: Uncaught Error: Call to undefined function Shaarli\Config\json_encode() in /var/www/html/shaarli/application/config/ConfigJson.php:48
Stack trace:
#0 /var/www/html/shaarli/application/config/ConfigManager.php(239): Shaarli\Config\ConfigJson->write('data/config.jso...', Array)
#1 /var/www/html/shaarli/index.php(1835): Shaarli\Config\ConfigManager->write(false)
#2 /var/www/html/shaarli/index.php(178): install(Object(Shaarli\Config\ConfigManager), Object(Shaarli\Security\SessionManager), Object(Shaarli\Security\LoginManager))
#3 {main}
thrown in /var/www/html/shaarli/application/config/ConfigJson.php on line 48

Tested with Shaarli 0.10.4 on CentOS 8 with Httpd 2.4.37 and PHP 7.2.11.

rfolo9li and others added 2 commits November 9, 2019 15:24
Without php-json the installation stops with a white screen and the following error:
> 09-Nov-2019 14:05:46 UTC] PHP Fatal error:  Uncaught Error: Call to undefined function Shaarli\Config\json_encode() in /var/www/html/shaarli/application/config/ConfigJson.php:48
> Stack trace:
> #0 /var/www/html/shaarli/application/config/ConfigManager.php(239): Shaarli\Config\ConfigJson->write('data/config.jso...', Array)
> #1 /var/www/html/shaarli/index.php(1835): Shaarli\Config\ConfigManager->write(false)
> #2 /var/www/html/shaarli/index.php(178): install(Object(Shaarli\Config\ConfigManager), Object(Shaarli\Security\SessionManager), Object(Shaarli\Security\LoginManager))
> #3 {main}
>   thrown in /var/www/html/shaarli/application/config/ConfigJson.php on line 48

Tested with Shaarli 0.10.4 on CentOS 8 with Httpd 2.4.37 and PHP 7.2.11.
Copy link
Member

@nodiscc nodiscc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nodiscc nodiscc self-assigned this Nov 9, 2019
@nodiscc nodiscc merged commit 99c7d66 into shaarli:master Nov 9, 2019
@ArthurHoaro
Copy link
Member

Thanks, however to be coherent it shouldn't be required as PHP JSON extension has been bundled with PHP core for a while now, but it should be related to RHEL like distributions.

@nodiscc
Copy link
Member

nodiscc commented Nov 10, 2019

On Debian php-json is in a separate package https://packages.debian.org/search?keywords=php-json

@ArthurHoaro
Copy link
Member

Right but it's a dependency of PHP main package. Anyway, it doesn't really matter, it doesn't harm to mention it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants