Reviewed Apache configuration #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(in documentation) For security purpose, block access to any static file not matching the list of allowed extensions. It allows us to remove the specific retriction on dotfiles, and fix Apache part of shaarli#1608.
|
I updated my instance with the new configuration. Everything looks good! |
|
Thanks! |
nodiscc
added a commit
to nodiscc/xsrv
that referenced
this pull request
Nov 11, 2020
nodiscc
added a commit
to nodiscc/xsrv
that referenced
this pull request
Nov 12, 2020
nodiscc
added a commit
to nodiscc/xsrv
that referenced
this pull request
Nov 15, 2020
nodiscc
added a commit
to nodiscc/xsrv
that referenced
this pull request
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(in documentation)
For security purpose, block access to any static file not matching the list of allowed extensions.
It allows us to remove the specific restriction on dotfiles, and fix Apache part of #1608.
Tested with AWS build of HTTPD: Apache/2.4.46.
I'm not super confident in my Apache config skills, so if you have some time to test it @nodiscc, @kcaran, or anyone running an Apache instance, it would be greatly appreciated:
data/user.cssREADME.md,yarn.lock,data/log.txt, etc. should not be accessible.