Github actions: update node #1928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devtty
commented
Dec 23, 2022
•
devtty
commented
- fixes tools: github actions: The ubuntu-18.04 environment is deprecated #1923 (updates to ubuntu-latest)
- fixes tools: github actions: Node.js 12 actions are deprecated #1924 (updates to node16-dependend actions)
- fixes tools: github actions: python: Unexpected input(s) 'node-version' #1925 (python action needs python-version)
nodiscc
reviewed
Dec 23, 2022
There was a problem hiding this comment.
Thank you very much. No warnings left.
OK for removing EOL PHP versions, Debian Stable and Ubuntu 18 have PHP 7.4, everyone should have migrated at this point. Maybe we should update the compatibility table at https://github.com/shaarli/Shaarli/blob/master/doc/md/Server-configuration.md#php to reflect this?
update compatibility table
|
😄 check if it is ok now |
|
Thank you! That's great! |
williamdes
reviewed
Mar 15, 2023
williamdes
reviewed
Mar 15, 2023
Co-authored-by: William Desportes <williamdes@wdes.fr>
williamdes
approved these changes
Mar 15, 2023
return to old PHP compatibility
williamdes
approved these changes
Mar 15, 2023
nodiscc
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.