New init function for plugins, supports errors reporting #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All plugins can optionally add an init function named `pluginname_init()` which is called when the plugin is loaded. This function is aware of the config, and can return initialization errors, which are displayed in the header template. Note that the previous error system hack no longer work.
Merged
20 tasks
virtualtam
reviewed
Oct 16, 2016
| { | ||
| $riyUrl = $conf->get('plugins.READITYOUSELF_URL'); | ||
| if (empty($riyUrl)) { | ||
| $error = 'Readityourself plugin error: '. |
There was a problem hiding this comment.
no need to assign a variable, an error array can be returned directly:
if (empty($riyUrl)) {
return array('Error message');
}There was a problem hiding this comment.
You're right, but when I'm dealing with a long string, I prefer to affect it before doing anything with it. I can change this if you think that's better.
There was a problem hiding this comment.
not a big deal, this could even come handy for more complex plugins that require checking several resources/config entries
| { | ||
| $wallabagUrl = $conf->get('plugins.WALLABAG_URL'); | ||
| if (empty($wallabagUrl)) { | ||
| $error = 'Wallabag plugin error: '. |
There was a problem hiding this comment.
no need to assign a variable, an error array can be returned directly:
if (empty($wallabagUrl)) {
return array('Error message');
}
virtualtam
approved these changes
Oct 16, 2016
| { | ||
| $riyUrl = $conf->get('plugins.READITYOUSELF_URL'); | ||
| if (empty($riyUrl)) { | ||
| $error = 'Readityourself plugin error: '. |
There was a problem hiding this comment.
not a big deal, this could even come handy for more complex plugins that require checking several resources/config entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All plugins can optionally add an init function named
pluginname_init()which is called when the plugin is loaded.This function is aware of the config, and can return initialization errors, which are displayed in the header template.
Note that the previous error system hack no longer work.