Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple sources for each composition #1480

Closed
bhajneet opened this issue Mar 6, 2020 · 6 comments · Fixed by #1481
Closed

Add support for multiple sources for each composition #1480

bhajneet opened this issue Mar 6, 2020 · 6 comments · Fixed by #1481
Assignees
Labels
Effort 8 Needs some splitting! Impacts All Affects nearly all or all end-users! □ Type Story Feature or requirement written from the user's perspective using non-technical language.

Comments

@bhajneet
Copy link
Member

bhajneet commented Mar 6, 2020

Would require support to have multiple lines for one line in one source. Potentially could require two of our current lines being one line in alternately published source.

All our corrections are being done with published sources. It would be easier to simply make corrections / catalog differences between these sources by looking at the published works.

Our current sources will be "deprecated" as we move to figuring out all lines being from which published sources. Where we know our sources are based on certain publications we can set them now.

Related to shabados/presenter#410 where we will have incomplete published sources.

There will eventually need to be a dragger of sorts allowing for prioritization of these published sources

@bhajneet bhajneet added □ Type Story Feature or requirement written from the user's perspective using non-technical language. Impacts Most Affects a majority of end-users. Status: Confirmed labels Mar 6, 2020
@bhajneet
Copy link
Member Author

bhajneet commented Mar 6, 2020

@Harjot1Singh need points on this

@bhajneet
Copy link
Member Author

bhajneet commented Mar 6, 2020

Originally posted in Slack by @sarabveer

Currently in Shabad OS: ਨਮੋ ਰਾਜ ਰਾਜੇਸ੍ਵਰੰ ਪਰਮ ਰੂਪੇ ॥੫੦॥
Nihung Santhia: ਨਮੋ ਰਾਜ ਰਾਜੇ ॥ ਸ੍ਵਰੰ ਪਰਮ ਰੂਪੇ ॥੫੦॥

SGPC:
ਕੈਸੀ ਆਰਤੀ ਹੋਇ ॥
ਭਵ ਖੰਡਨਾ ਤੇਰੀ ਆਰਤੀ ॥
Talwara Ji: ਕੈਸੀ ਆਰਤੀ ਹੋਇ ਭਵ ਖੰਡਨਾ ਤੇਰੀ ਆਰਤੀ ॥

@bhajneet
Copy link
Member Author

bhajneet commented Mar 6, 2020

Originally posted in Slack by @Harjot1Singh

// previous lines
,{
  id: '21WF',
  gurmukhi: {
      sgpc: 'ਨਮੋ ਰਾਜ ਰਾਜੇਸ੍ਵਰੰ ਪਰਮ ਰੂਪੇ ॥੫੦॥'
      ns: 'ਨਮੋ ਰਾਜ ਰਾਜੇ ॥'
  }
},
{
  id: 'G1GH',
  gurmukhi: {
      ns: ' ਸ੍ਵਰੰ ਪਰਮ ਰੂਪੇ ॥੫੦॥'
     // Notice how SGPC is missing. And that's OK. We won't include the row/data when they use that source.
  }
},
// next lines

@Harjot1Singh
Copy link
Member

We need to adapt DB viewer too btw

@Harjot1Singh Harjot1Singh added the Effort 8 Needs some splitting! label Mar 6, 2020
@bhajneet bhajneet added Impacts All Affects nearly all or all end-users! and removed Impacts Most Affects a majority of end-users. labels Mar 7, 2020
@bhajneet
Copy link
Member Author

bhajneet commented Mar 12, 2020

Est difficulty range 21
Actual difficulty 6

@sarabveer
Copy link
Collaborator

sarabveer commented Mar 12, 2020

Related #95

@bhajneet bhajneet changed the title Add support for multiple published sources Add support for multiple sources for each composition Mar 16, 2020
@sarabveer sarabveer mentioned this issue Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort 8 Needs some splitting! Impacts All Affects nearly all or all end-users! □ Type Story Feature or requirement written from the user's perspective using non-technical language.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants