Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proofread and Correct Jaap Sahib according to SGPC (2nd Pass) #97

Merged
merged 5 commits into from
Jan 31, 2019
Merged

Proofread and Correct Jaap Sahib according to SGPC (2nd Pass) #97

merged 5 commits into from
Jan 31, 2019

Conversation

sarabveer
Copy link
Collaborator

@sarabveer sarabveer commented Jan 22, 2019 •
edited
Loading

Source: ਨਿਤਨੇਮ ਤੇ ਹੋਰ ਬਾਣੀਆ, SGPC, May 2017

PDF: https://goo.gl/zvcDb9
Sri Dasam Granth/Nitnem Gutka - Dasam Baani (SGPC).pdf
PDF Pages: 10, 11, 14, 15, 16, 17, 18, 21, 22, 24, 26

Closes #103 #123 #124

@sarabveer
Proofread and Correct Jaap Sahib according to SGPC (2nd Pass)
50f2ee1 
Source: ਨਿਤਨੇਮ ਤੇ ਹੋਰ ਬਾਣੀਆ, SGPC, May 2017
@sarabveer sarabveer added Scope: Data/Sri Dasam Granth ○ Type Bug Regressions/production issues that do not function as intended. labels Jan 22, 2019
@sarabveer sarabveer self-assigned this Jan 22, 2019
Harjot1Singh
Harjot1Singh previously approved these changes Jan 27, 2019
View reviewed changes
bhajneet
bhajneet requested changes Jan 31, 2019
View reviewed changes
Copy link
Member

@bhajneet bhajneet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except for many Adhaks missing (not all mentioned in comments, have found others too).

data/Sri Dasam Granth/0007.json Show resolved Hide resolved
Harjot1Singh
Harjot1Singh approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@Harjot1Singh Harjot1Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Harjot1Singh Harjot1Singh merged commit dd95545 into master Jan 31, 2019
@Harjot1Singh Harjot1Singh deleted the jaap-sahib branch January 31, 2019 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harjot1Singh Harjot1Singh Harjot1Singh approved these changes

@bhajneet bhajneet bhajneet approved these changes

Assignees

@sarabveer sarabveer

Labels
Scope: Data/Sri Dasam Granth ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarabveer @Harjot1Singh @bhajneet