Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add open yaiya characters #164

Merged
merged 2 commits into from
Jun 6, 2020
Merged

feat: add open yaiya characters #164

merged 2 commits into from
Jun 6, 2020

Conversation

sarabveer
Copy link
Collaborator

@sarabveer sarabveer commented Jun 5, 2020 •
edited
Loading

Summary of PR

Adds open yaiya characters to Unicode converter and English transliteration

Linked issues

Fix #135

@sarabveer sarabveer added Impacts All Affects nearly all or all end-users! □ Type Story Feature or requirement written from the user's perspective using non-technical language. Effort 0 Non-work/tracking. labels Jun 5, 2020
@sarabveer sarabveer marked this pull request as ready for review June 5, 2020 21:27
Harjot1Singh
Harjot1Singh requested changes Jun 6, 2020
View reviewed changes
Copy link
Member

@Harjot1Singh Harjot1Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the test for toEnglish

@sarabveer
Copy link
Collaborator Author

Add the test for toEnglish

Test isn't needed as the tests are mainly for the rules, not the mappings. Functionality is the same as regular yaiya which has no test.

@Harjot1Singh
Copy link
Member

Add the test for toEnglish

Test isn't needed as the tests are mainly for the rules, not the mappings. Functionality is the same as regular yaiya which has no test.

Ok, happy with that reasoning.

@Harjot1Singh Harjot1Singh merged commit 5452ef2 into shabados:master Jun 6, 2020
@sarabveer sarabveer deleted the add-open-yaiya branch March 17, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harjot1Singh Harjot1Singh Harjot1Singh requested changes

Assignees
No one assigned
Labels
Effort 0 Non-work/tracking. Impacts All Affects nearly all or all end-users! □ Type Story Feature or requirement written from the user's perspective using non-technical language.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add transliteration of yaiya variations
2 participants
@sarabveer @Harjot1Singh