Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: migrate to GH actions #171

Merged
merged 5 commits into from
Oct 26, 2020
Merged

ci: migrate to GH actions #171

merged 5 commits into from
Oct 26, 2020

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Oct 20, 2020

Summary of PR

Migrate CCI workflow to GH actions. I split it into 2 workflows one for CI which runs tests and listing and CD for building and deploying to NPM

For Maintainers

  • Setup secret NPM_BOT_TOKEN

Time spent on PR

30 mins

Demo

For some reason npm run publish-coverage is not working. I don't know if this is something I need add a secret or something for coveralls.
https://github.com/saihaj/ShabadOSgurmukhi-utils/actions/runs/324357425

Linked issues

Ongoing migration process

Reviewers

@Harjot1Singh @bhajneet

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@saihaj
Copy link
Member Author

saihaj commented Oct 23, 2020

I rebased mine with dev. I think it probably has something to do with readme 🤷🏼‍♂️ ?

Copy link
Member

@Harjot1Singh Harjot1Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just this one change!

package.json Outdated Show resolved Hide resolved
@Harjot1Singh Harjot1Singh merged commit e4d3bd5 into shabados:dev Oct 26, 2020
@saihaj saihaj deleted the migrate-cci branch November 3, 2020 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants