Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: skip npm checks when running release script #184

Merged
merged 1 commit into from
Nov 4, 2020
Merged

ci: skip npm checks when running release script #184

merged 1 commit into from
Nov 4, 2020

Conversation

Harjot1Singh
Copy link
Member

Summary of PR

Fixes "Error Not authenticated"

Errors out unnecessarily, as per release-it/release-it#704

Reviewers

@saihaj

@coveralls
Copy link

Pull Request Test Coverage Report for Build 346411956

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 344378110: 0.0%
Covered Lines: 153
Relevant Lines: 153
💛 - Coveralls

saihaj
saihaj approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's finally release this

@Harjot1Singh Harjot1Singh merged commit adfc094 into shabados:dev Nov 4, 2020
@Harjot1Singh Harjot1Singh deleted the fix-release-it-ci-publish branch November 4, 2020 22:26
@saihaj saihaj mentioned this pull request Jun 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saihaj saihaj saihaj approved these changes

Assignees

@saihaj saihaj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Harjot1Singh @coveralls @saihaj