Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add third party port #187

Merged
merged 1 commit into from
Feb 18, 2021
Merged

docs: add third party port #187

merged 1 commit into from
Feb 18, 2021

Conversation

bhajneet
Copy link
Member

Summary of PR

Added a third party ports section

Time spent on PR

5 minutes

Reviewers

@Harjot1Singh

@coveralls
Copy link

Pull Request Test Coverage Report for Build 572864462

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 346416254: 0.0%
Covered Lines: 153
Relevant Lines: 153

💛 - Coveralls

@saihaj
Copy link
Member

saihaj commented Feb 16, 2021

@bhajneet we need to sync this in docs repo too?

@bhajneet
Copy link
Member Author

@bhajneet we need to sync this in docs repo too?

Where is this synced in the docs repo?

@saihaj
Copy link
Member

saihaj commented Feb 17, 2021

@bhajneet we need to sync this in docs repo too?

Where is this synced in the docs repo?

Yes. https://github.com/shabados/docs/pull/15

@bhajneet
Copy link
Member Author

So it looks like you're still discussing it there with Harjot. I think this PR can go in without needing to resolve that right away

@saihaj
Copy link
Member

saihaj commented Feb 17, 2021

I guess Harjot forgot to reply
and I also forgot to ping back. I will sync this one once this gets merged here. Definitely we need a better way to sync docs.

@Harjot1Singh
Copy link
Member

I'd probably rename it to community instead of 3rd party, but not fussed. Change as you see fit, will approve now and LGTM

@bhajneet bhajneet merged commit c7e9651 into shabados:dev Feb 18, 2021
@saihaj saihaj mentioned this pull request Jun 12, 2021
@bhajneet bhajneet deleted the update-readme branch January 11, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Impacts Few Does not affect many end-users.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants