New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the return type of composite_channel_credentials #12

Merged

shabbyrobe merged 1 commit into shabbyrobe:master from dalazx:composite_channel_credentials_fix

Feb 11, 2021

Contributor

dalazx commented Feb 10, 2021 •

edited

Loading

Likely a copy-paste artifact.
The implementation does return ChannelCredentials:
https://github.com/grpc/grpc/blob/a72c72f6e353ffeba7d3a268e7daa8916d48dac0/src/python/grpcio/grpc/__init__.py#L1672-L1687


          Fix the return type of composite_channel_credentials

75b6cf9

Owner

shabbyrobe commented Feb 11, 2021

This is great, thanks for the pickup!

shabbyrobe merged commit a157c0c into shabbyrobe:master

KapJI mentioned this pull request

Publish new version #16

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment