Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept any Iterable for service_names #51

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Accept any Iterable for service_names #51

merged 1 commit into from
Sep 29, 2023

Conversation

dimo414
Copy link
Contributor

@dimo414 dimo414 commented Sep 21, 2023

Description of change

Passing a set works for me locally, but then Mypy gets mad because of this type hint.

Checklist:

  • I have verified my MRE is sufficient to demonstrate the issue and solution by attempting to execute it myself
    • OR I believe my contribution is minor enough that a typing test is sufficient.
  • I have added tests to typesafety/test_grpc.yml for all APIs added or changed by this PR
  • I have removed any code generation notices from anything seeded using mypy-protobuf.

@dimo414
Accept any Iterable for service_names
70be9cc 
Passing a set works for me locally, but then Mypy gets mad because of this type hint.
@shabbyrobe shabbyrobe merged commit 37d5ef6 into shabbyrobe:master Sep 29, 2023
0 of 4 checks passed
@dimo414 dimo414 deleted the patch-1 branch September 29, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimo414 @shabbyrobe