Feature/rails error handling improved #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcGrimme
changed the title
MarcGrimme
force-pushed
the
feature/rails-error-handling-improved
branch
2 times, most recently
from
04ed8b2
to
2738115
Compare
lib/logstasher/railtie.rb
Outdated
| config.after_initialize do | ||
| initializer :logstasher do |app| | ||
| app.config.middleware.use ::LogStasher::ActionDispatch::DebugExceptions | ||
| app.config.middleware.delete ::ActionDispatch::DebugExceptions if Rails.env.production? |
There was a problem hiding this comment.
Why do not use this condition on :use method?
E.g.
app.config.middleware.use ::LogStasher::ActionDispatch::DebugExceptions unless Rails.env.production?
MarcGrimme
force-pushed
the
feature/rails-error-handling-improved
branch
2 times, most recently
from
1576108
to
dc69286
Compare
MarcGrimme
changed the title
MarcGrimme
force-pushed
the
feature/rails-error-handling-improved
branch
from
2ca49ea
to
67e51e6
Compare
…ce the old logs if suppress_app_logs. Closes shadabahmed#79
MarcGrimme
force-pushed
the
feature/rails-error-handling-improved
branch
from
67e51e6
to
9e089db
Compare
…::DebugExceptions so that it can be used outside as well.
shadabahmed
force-pushed
the
master
branch
2 times, most recently
from
d37188e
to
9480e28
Compare
shadabahmed
force-pushed
the
main
branch
4 times, most recently
from
aa5da57
to
f28e910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: Currently mostly all errors happing in the app that should be caught by the rack middleware are logged as normal text output which is wrong. Expected would be some json.
This PR adds a middleware
::Logstasher::ActionDispatch::DebugExceptionsto the stack that will just do the logging. This middleware will just sit on top of::ActionDispatch.:DebugExceptions.If
suppress_app_logsis switched on it also needs to silence theaction_dispatch.logger. This is done by replacing it with the::LogStasher::NullLoggeranother helper class to make this happen. This part I'm not so proud of cause it should not be necessary but after a long time of struggling I think it is the best I can come up with.So have fun testing.
Comments welcome.
Try to fix #79