Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null-safety related refactors #6

Closed
wants to merge 2 commits into from
Closed

Null-safety related refactors #6

wants to merge 2 commits into from

Conversation

bryancalisto
Copy link

@bryancalisto bryancalisto commented Oct 14, 2021 •
edited
Loading

  • Made 'child' field non-nullable in DraggableFab class.
  • Added internet permission in Example project's AndroidManifest.
  • Changed dart sdk in Example project's pubspec.yaml.

@shadabunique
Copy link
Owner

Sorry, but your PR broke the functionality- Dragging the FAB is moving it back to the original position.

@bryancalisto
Copy link
Author

Sorry, but your PR broke the functionality- Dragging the FAB is moving it back to the original position.

Yes, my bad. I was experimenting and forgot to uncomment a setState() line I had commented before making the commit. I am sorry. But I see you just implemented my changes yourself. Thank you 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadabunique shadabunique shadabunique left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bryancalisto @shadabunique