-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added remix and tabbed installation docs #753
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
@mdloop is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Not sure what the procedure is in regards to changesets as it relates to the docs website. Let me know if I you want me to include something there as well. |
Hi, I really thank you for your help! Actually I was thinking about having the docs page structured like this: ---
title: Installation
description: How to install dependencies and structure your app.
---
<Tabs defaultValue="nextjs">
<TabsList>
<TabsTrigger value="nextjs">
Next.js
</TabsTrigger>
<TabsTrigger value="vite">
Vite
</TabsTrigger>
</TabsList>
<TabsContent value="nextjs">
<FrameworkDocs data="nextjs" />
</TabsContent>
<TabsContent value="vite">
<FrameworkDocs data="vite" />
</TabsContent>
<TabsContent value="remix">
<FrameworkDocs data="remix" />
</TabsContent>
... With the folder The Vite Docs page (with tabs) is already under development here #714. |
Sounds good. Let me take a look and follow that. Is there any other branches I need to track into this one in order to do this? |
On second look. This seems like sometimes we can do pretty quickly. Expect something today. With no other branches. |
Just #714 for now.
Awesome! |
@dan5py @samuelkurdz I've added the tabs and included the vite documentation as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create the folder installation
and move the content of the file installation.mdx
to installation/index.mdx
. Then put all the frameworks docs inside that folder (I think it's cleaner like this).
Please also remove the vite docs for now, I want that @samuelkurdz adds it when this gets merged (he deserves the credits).
BTW you are doing a really great job! |
100%!!! |
Your update is actually wayyy cleaner!! |
@dan5py @samuelkurdz Should be good now. If this can be merged, then @samuelkurdz can update his PR to add vite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
* docs: add react with vite installation guide * refactor(docs): move Ract with vite page into installation.mdx as tab * fix(docs): remove classnames and wrapper divs * fix(docs): update tsconfig file path to default @ * feat: added remix installation docs * feat: added tabbed installation docs * fix: remove log statement * fix: cleaned up, restored usage notice, removed vite for now * fix: moved installation.mdx into folder --------- Co-authored-by: Samuel Adebayo <samuel.adebayo@engagetech.com> Co-authored-by: shadcn <m@shadcn.com>
* docs: add react with vite installation guide * refactor(docs): move Ract with vite page into installation.mdx as tab * fix(docs): remove classnames and wrapper divs * fix(docs): update tsconfig file path to default @ * feat: added remix installation docs * feat: added tabbed installation docs * fix: remove log statement * fix: cleaned up, restored usage notice, removed vite for now * fix: moved installation.mdx into folder --------- Co-authored-by: Samuel Adebayo <samuel.adebayo@engagetech.com> Co-authored-by: shadcn <m@shadcn.com>
This PR adds installation documentation for Remix. Tested with the current version of Remix, Tailwind et cetera as of today.
Also adds nifty little tabs.