Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(www): Improve Gatsby guide #826

Merged
merged 1 commit into from
Jul 4, 2023
Merged

docs(www): Improve Gatsby guide #826

merged 1 commit into from
Jul 4, 2023

Conversation

LekoArts
Copy link
Contributor

@LekoArts LekoArts commented Jul 4, 2023

Hi!

Gatsby maintainer here 👋 I stumbled upon the Gatsby guide and have some suggestions for improvements. Comments are inlined in the PR

@vercel
Copy link

vercel bot commented Jul 4, 2023

@LekoArts is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jul 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 6:42am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-template ⬜️ Ignored (Inspect) Jul 4, 2023 6:42am


```bash
npx gatsby new
npm init gatsby
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use npm init / yarn create normally for our Quick Start guides, see https://www.gatsbyjs.com/docs/quick-start/

@@ -52,13 +52,14 @@ Add the code below to the tsconfig.json file to resolve paths:
}
```

### Create gatsby-node.js file
### Create gatsby-node.ts file
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LekoArts 🙏

@shadcn shadcn merged commit cbe0f19 into shadcn-ui:main Jul 4, 2023
7 checks passed
@LekoArts LekoArts deleted the patch-1 branch July 4, 2023 07:17
suleymanbariseser pushed a commit to suleymanbariseser/shadcn-ui that referenced this pull request Jul 25, 2023
kjxbyz pushed a commit to muse-ui/muse-ui that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants