Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite public API and update to v246 of LIBLINEAR #5

Merged
merged 22 commits into from
Apr 2, 2023

Conversation

shadeMe
Copy link
Owner

@shadeMe shadeMe commented Apr 2, 2023

LGTM! :trollface:

Refactor main module into submodules
Add one-class solver type
Add default impls for builders
Build fixes
Doc fixes
…er features

Remove `Problem` abstraction
Remove builders
Port parameter validation checks to Rust-land
Reorganize as `cargo` workspace
Add `liblinear-macros` crate
Tick C++ library to v246
Fix bounds checking in `ModelBase::feature_coefficient`
Update docstrings
…ion solvers

Add unit test for parameter validation
Test `ModelBase::feature_coefficient`
Fix test constants
Update `Cargo.toml`
@shadeMe shadeMe merged commit 28870f8 into master Apr 2, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant