Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to create, edit, and display GLSL and JS sculptures in the same environment #11

Closed
PWhiddy opened this issue May 23, 2019 · 2 comments
Closed

Ability to create, edit, and display GLSL and JS sculptures in the same environment #11

PWhiddy opened this issue May 23, 2019 · 2 comments
Assignees
@torinmb @PWhiddy
Labels
feature v0.1

Comments

@PWhiddy
Copy link
Member

PWhiddy commented May 23, 2019

No description provided.

@PWhiddy PWhiddy added the v0.1 label May 23, 2019
@PWhiddy PWhiddy changed the title Ability to create, edit, and display GLSL and JS sculptures in the save environment Ability to create, edit, and display GLSL and JS sculptures in the same environment May 23, 2019
@PWhiddy PWhiddy mentioned this issue May 23, 2019
Closed
torinmb added a commit that referenced this issue May 24, 2019
@torinmb
save, load glsl + js sculptures
060129c 
closes #11
@torinmb
Copy link
Member

torinmb commented May 24, 2019

This also fixed a bug in saving. works as intended where the user is notified if they don't save. they can go to another sculpture. then go back and the editor will still recognize that it wasn't saved.

It could be useful to prevent someone from navigating to another route without saving / we could prompt them with the same pop up before they navigate away with unsaved changes.

@torinmb
Copy link
Member

torinmb commented May 24, 2019

actually, wait that's a huge problem when you're editing a sculpture in /new. #41

@torinmb torinmb closed this as completed May 24, 2019
PWhiddy pushed a commit that referenced this issue May 31, 2019
@torinmb
save, load glsl + js sculptures
f4da3c1 
closes #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@torinmb torinmb

@PWhiddy PWhiddy

Labels
feature v0.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@torinmb @PWhiddy