Skip to content

Commit

Permalink
This commit increases the minimum CMake version from 3.20 to 3.25. (#…
Browse files Browse the repository at this point in the history
…4193)

I was trying to see if I can lower it to 3.16, but I found that we are currently using CMake feature that requires a version 3.25 not 3.20.

This finding is not new. I made a similar change to CMakePresets.json a few days ago. At that time, I didn't realize that the same change had to be made for CMakeList.txt as well.
  • Loading branch information
jkwak-work committed May 21, 2024
1 parent e913cb9 commit 52b5bb4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 3.20)
cmake_minimum_required(VERSION 3.25)

# Our module dir, include that now so that we can get the version automatically
# from git describe
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTION.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ Install CMake and Ninja.
```
$ sudo apt-get install cmake ninja-build
```
> Warning: Currently the required CMake version is 3.20 or above.
> Warning: Currently the required CMake version is 3.25 or above.
Run CMake with a following command to generate Makefile:
```
Expand Down

0 comments on commit 52b5bb4

Please sign in to comment.