Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve organization of release assets #4528

Closed
chaoticbob opened this issue Jul 2, 2024 · 3 comments · Fixed by #3703
Closed

Improve organization of release assets #4528

chaoticbob opened this issue Jul 2, 2024 · 3 comments · Fixed by #3703
Assignees
Labels
goal:client support Feature or fix needed for a current slang user. kind:cleanup tech debt and rough edges siggraph2024 Issue targeting SIGGRAPH 2024

Comments

@chaoticbob
Copy link
Collaborator

chaoticbob commented Jul 2, 2024

Header Files
Can the header files that's located in the root of all the release asset zip and tar.gz files be moved into an include or inc or maybe even a include/slang or inc/slang? There's not a strong technical argument for this but for project setups this makes it more obvious what the path entry is doing.

Binaries
Currently, the binaries are located a few directories down from the root itself: bin/<platform>/release/[slangc, *.so, *.dll]. Is possible to trim down a bit? Since the release assets already have the platform name, can the binary content just be in bin directory?

@ArielG-NV ArielG-NV added kind:cleanup tech debt and rough edges goal:client support Feature or fix needed for a current slang user. labels Jul 2, 2024
@bmillsNV bmillsNV added the siggraph2024 Issue targeting SIGGRAPH 2024 label Jul 2, 2024
@bmillsNV bmillsNV added this to the Q3 2024 (Summer) milestone Jul 2, 2024
@bmillsNV bmillsNV changed the title Improve organization of release asset header files Improve organization of release assets Jul 2, 2024
@bmillsNV
Copy link
Collaborator

bmillsNV commented Jul 2, 2024

if we make a change - some concerns about backwards compatibility. Maybe just put in the release notes? @ArielG-NV to propose something, then we can get alignment and move forward in the next sprint.

@expipiplus1
Copy link
Collaborator

This should be fixed by #3703

@ArielG-NV
Copy link
Collaborator

ArielG-NV commented Jul 4, 2024

if we make a change - some concerns about backwards compatibility. Maybe just put in the release notes? @ArielG-NV to propose something, then we can get alignment and move forward in the next sprint.

Seeing what @expipiplus1 said

This should be fixed by #3703

It seems this task is already being handled by @expipiplus1?

@expipiplus1 expipiplus1 self-assigned this Jul 5, 2024
@ArielG-NV ArielG-NV removed their assignment Jul 5, 2024
@swoods-nv swoods-nv linked a pull request Jul 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:client support Feature or fix needed for a current slang user. kind:cleanup tech debt and rough edges siggraph2024 Issue targeting SIGGRAPH 2024
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants