cmake: option to build a static library version of slang #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fknfilewalker
changed the title
|
ok looks good, I think that the name would be better as |
|
@fknfilewalker just to make sure, you've tested this and it's useful to you right? If so then it's good to merge. |
csyonghe
approved these changes
Feb 16, 2024
|
Yes I did run it. The only downside is the quite large lib size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to cmake that allows to build and link a static version of the slang library.
The resulting
slang.libis about 1 GB in size in debug, which is a bit on the larger side but I don't know why.