-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPIR-V SV_InstanceId
support in pixel shader
#4368
Merged
csyonghe
merged 10 commits into
shader-slang:master
from
ArielG-NV:HLSL-SV_InstanceId-not-supported-in-pixel-shader-#3087
Jun 13, 2024
Merged
SPIR-V SV_InstanceId
support in pixel shader
#4368
csyonghe
merged 10 commits into
shader-slang:master
from
ArielG-NV:HLSL-SV_InstanceId-not-supported-in-pixel-shader-#3087
Jun 13, 2024
Commits on Jun 12, 2024
-
solve issue by making 'non SV for SPIRV' system semantics, no longer …
…an SV once diagnosed by slang Problem: 1. SV_InstanceID (HLSL) is allowed as an output semantic with HLSL, it is also allowed for input into pixel shader. We need to account for multiple entry points in 1 file using both of these scenarios at once. 2. SPIRV does not allow `SV_InstanceID` as a builtin, `SV_InstanceID` must be passed as a regular `flat` `Input` from vertex shader. Solution: Slang needs to treat these SV objects as non built-in's. As a result: 1. Slang needs to allocate for vertex output and fragment Input binding slots for all SV_InstanceID uses (if the target is SPIRV). This allows Slang to prepare an open slot to bind these SV objects to. 2. Slang needs to not emit built in modifier for these not actual built in variables (under the specific circumstances described). note: `VarLayout` was made not `HOISTABLE` since I don't believe it needs to be `HOISTABLE`. * The code can be made to work even if `VarLayout` is `HOISTABLE`.
Configuration menu - View commit details
-
Copy full SHA for fef8f00 - Browse repository at this point
Copy the full SHA fef8f00View commit details -
Configuration menu - View commit details
-
Copy full SHA for 673f64e - Browse repository at this point
Copy the full SHA 673f64eView commit details
Commits on Jun 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6c69fed - Browse repository at this point
Copy the full SHA 6c69fedView commit details -
address review comments and reimplement operand removal
1. remove an operand by selectively copying operands 2. test to ensure `Flat` is in the test shaders * we do not need to manually add `Flat` in the code since this is done for us in emit-spirv. This is the behavior since `uint` on a fragment `Input` must be `Flat`, else it is a VK validation error.
Configuration menu - View commit details
-
Copy full SHA for 5492caa - Browse repository at this point
Copy the full SHA 5492caaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 313e8ec - Browse repository at this point
Copy the full SHA 313e8ecView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25f0b92 - Browse repository at this point
Copy the full SHA 25f0b92View commit details -
Merge branch 'HLSL-SV_InstanceId-not-supported-in-pixel-shader-shader…
…-slang#3087' of https://github.com/ArielG-NV/slang into HLSL-SV_InstanceId-not-supported-in-pixel-shader-shader-slang#3087
Configuration menu - View commit details
-
Copy full SHA for e87b2df - Browse repository at this point
Copy the full SHA e87b2dfView commit details -
remove unused function reserve instead of setCount with ShortList
Configuration menu - View commit details
-
Copy full SHA for 1cb22e4 - Browse repository at this point
Copy the full SHA 1cb22e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a38ec4a - Browse repository at this point
Copy the full SHA a38ec4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b6493b - Browse repository at this point
Copy the full SHA 3b6493bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.