Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add case to emitVectorReshape for when using a vector<M, N> type with T value #4419

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Add case to emitVectorReshape for when using a vector<M, N> type with T value #4419

merged 7 commits into from
Jun 24, 2024

Conversation

ArielG-NV
Copy link
Collaborator

fixes: #4411

  1. Add logic to handle vector<> type, scalar value in emitVectorReshape
    • construct a vector based on the input type either a vec1 to vecn. Any elements beyond index 0 are a default value for the "vector<> type, scalar value" case
  2. Add test

@ArielG-NV ArielG-NV added the pr: non-breaking PRs without breaking changes label Jun 18, 2024
@ArielG-NV ArielG-NV changed the title Add case to emitVectorReshape for vector<> type, scalar value Add case to emitVectorReshape for parameters (vector<M, N> type, T value) Jun 21, 2024
@ArielG-NV ArielG-NV changed the title Add case to emitVectorReshape for parameters (vector<M, N> type, T value) Add case to emitVectorReshape for when using a vector<M, N> type with T value Jun 21, 2024
@ArielG-NV ArielG-NV merged commit 8d2f6e4 into shader-slang:master Jun 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csyonghe csyonghe csyonghe approved these changes

Assignees
No one assigned
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IR: emitVectorReshape fails if param type is a vector whilst param value is a scalar
2 participants
@ArielG-NV @csyonghe