libmisc: Accept --root=path and --prefix=path option syntax #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recognise --root=path in addition to --root path (and similarly for --prefix) to match the syntax accepted by getopt_long. Fixes shadow-maint#218
|
Note that this does not attempt to fix parsing of short option syntax. Variants such as "-Rpath", "-eRpath" and "-eR path" will still be ignored. Instead of trying to fix that in process_root_flag(), it might be better to refactor process_flags() and check_flags() so that only getopt_long() is used for argument parsing. But that's for another day. |
|
Thank you. Indeed refactoring might be good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recognise --root=path in addition to --root path (and similarly for
--prefix) to match the syntax accepted by getopt_long.
Fixes #218