Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add robot descriptions to sr-config #20

Open
kirstyellis opened this issue May 21, 2015 · 1 comment
Open

add robot descriptions to sr-config #20

kirstyellis opened this issue May 21, 2015 · 1 comment
Assignees

Comments

@kirstyellis
Copy link
Contributor

to aid with issue#19

@guihomework
Copy link
Contributor

@kirstyellis I have seen xacro files (not urdf files) have been added to sr-config now. This is rather strange.
I thought sr-config was meant to configure the hand per customer (settings, mappings, tuning, calib, OPTENV for muscle/motor tactile edc/can selection etc).

Indeed the urdf is usually also really tightly related to the customer hand. But the urdf.xacro where made generic (I did) to handle the customer settings actually. Xacro files are not per customer but rather generic I would say.

to get per customer files, to my opinion there should be a specific urdf file, with the correct pre-generated urdf into the sr_config, or at least a CMakeLists.txt xacro generation in sr_config with the correct args (depending on the customer) to create the pre-generated urdf into sr_config at compile time.

putting urdf.xacro out or sr_description is non-standard to me.

what do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants