Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple workers #33

Closed
robgjansen opened this issue Oct 28, 2011 · 2 comments
Closed

Support multiple workers #33

robgjansen opened this issue Oct 28, 2011 · 2 comments
Assignees
@robgjansen
Labels
X-Archive: Shadow [Deprecated label.] Associated with the core Shadow code.
Milestone
release-1.5.0

Comments

@robgjansen
Copy link
Member

Multiple worker threads can improve shadow's parallelism. We need to make sure each plugin has private versions of libraries, private errno, the intercept library is stateless, and we handle all the other issues that multiple threads will cause.
robgjansen added a commit that referenced this issue Jan 16, 2012
@robgjansen
Tests for multi-worker mode.
82a63fc 
refs #33
robgjansen added a commit that referenced this issue Feb 25, 2012
@robgjansen
Fixed plug-in callback issue
dd700f4 
Fixed problem where worker threads were calling callbacks from other
threads' private plugins. We now have to bind symbols locally to allow
multiple versions of the same plug-in.

refs #33
@robgjansen robgjansen reopened this Mar 27, 2012
@robgjansen
Copy link
Member Author

Plug-ins using OpenSSL are not yet thread-safe. We need to set callbacks as defined in

man CRYPTO_lock

@ghost ghost assigned robgjansen Mar 28, 2012
robgjansen added a commit that referenced this issue Mar 28, 2012
@robgjansen
Locking and thread id functions for openssl
49b4795 
OpenSSL requires a thread locking function and id function to be thread
safe. This is an interim commit as there are still problems running
scallion.

refs #33
@robgjansen
Copy link
Member Author

I believe multiple workers are functional if the plug-in is properly multi-threaded. Scallion does not work at this time with multiple workers, but the other plugins do. This should be fixed in Shadow/Tor.

I'm closing this, as the multi-threaded engine is functional.

@lamiaaMB lamiaaMB mentioned this issue Jan 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robgjansen robgjansen

Labels
X-Archive: Shadow [Deprecated label.] Associated with the core Shadow code.
Projects
None yet
Milestone
release-1.5.0
Development

No branches or pull requests
1 participant
@robgjansen