Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for socketpair syscall #1058

Merged
merged 3 commits into from Dec 17, 2020
Merged

Add support for socketpair syscall #1058

merged 3 commits into from Dec 17, 2020

Conversation

robgjansen
Copy link
Member

Passes all existing socketpair tests.

refs #849

@robgjansen robgjansen added Type: Enhancement New functionality or improved design Component: Main Composing the core Shadow executable labels Dec 16, 2020
@robgjansen robgjansen self-assigned this Dec 16, 2020
@codecov
Copy link

codecov bot commented Dec 16, 2020

Codecov Report

Merging #1058 (41e0c30) into dev (b963f5e) will increase coverage by 0.25%.
The diff coverage is 90.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1058      +/-   ##
==========================================
+ Coverage   54.82%   55.07%   +0.25%     
==========================================
  Files         127      127              
  Lines       19177    19231      +54     
  Branches     4585     4592       +7     
==========================================
+ Hits        10513    10592      +79     
+ Misses       5898     5871      -27     
- Partials     2766     2768       +2     
Flag Coverage Δ
tests 55.07% <90.58%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/host/descriptor/descriptor_table.c 68.35% <0.00%> (+2.10%) ⬆️
src/main/host/descriptor/transport.c 64.28% <ø> (ø)
src/main/host/syscall/uio.c 0.00% <ø> (ø)
src/main/host/descriptor/channel.c 65.47% <66.66%> (+4.76%) ⬆️
src/main/host/syscall/socket.c 73.83% <92.20%> (+1.77%) ⬆️
src/main/host/syscall/unistd.c 57.30% <100.00%> (ø)
src/main/host/syscall_handler.c 53.11% <100.00%> (+0.22%) ⬆️
src/shim/preload_syscalls.c 47.76% <100.00%> (+0.23%) ⬆️
src/main/core/slave.c 68.95% <0.00%> (+0.65%) ⬆️
src/main/host/thread_ptrace.c 66.61% <0.00%> (+0.87%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b963f5e...8b11ec8. Read the comment docs.

@robgjansen robgjansen marked this pull request as ready for review December 17, 2020 13:05
return (SysCallReturn){.state = SYSCALL_DONE, .retval.as_i64 = -EPROTONOSUPPORT};
}

/* TODO: should we actually be running TCP/UDP internally (i.e., using already connected TCP/UDP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I don't know of a reason why we'd want that

@robgjansen robgjansen merged commit 4cc05c3 into shadow:dev Dec 17, 2020
@robgjansen robgjansen deleted the syscall-socketpair branch December 17, 2020 16:14
@robgjansen robgjansen linked an issue Dec 17, 2020 that may be closed by this pull request
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Main Composing the core Shadow executable Type: Enhancement New functionality or improved design
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants