Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rand, rand_core, and rand_chacha crates #1062

Merged
merged 1 commit into from
Dec 21, 2020
Merged

Upgrade rand, rand_core, and rand_chacha crates #1062

merged 1 commit into from
Dec 21, 2020

Conversation

stevenengler
Copy link
Contributor

This PR replaces #1054, #1055, #1061 since all of these packages need to be upgraded simultaneously.

@stevenengler stevenengler added the Component: Build Build/install tools and dependencies label Dec 21, 2020
@stevenengler stevenengler added Priority: Low Prioritized below most other issues Status: Accepted Bug is reproducible or effort is allocated Type: Maintenance Refactoring, cleanup, documenation, or process improvements labels Dec 21, 2020
@codecov
Copy link

codecov bot commented Dec 21, 2020

Codecov Report

Merging #1062 (453d510) into dev (931e067) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1062      +/-   ##
==========================================
+ Coverage   55.02%   55.07%   +0.04%     
==========================================
  Files         127      127              
  Lines       19246    19235      -11     
  Branches     4595     4590       -5     
==========================================
+ Hits        10591    10593       +2     
+ Misses       5884     5870      -14     
- Partials     2771     2772       +1     
Flag Coverage Δ
tests 55.07% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/test/pthreads/test_pthreads.c 41.71% <0.00%> (-0.58%) ⬇️
src/support/logger/rust_bindings/src/lib.rs 31.87% <0.00%> (-0.08%) ⬇️
.../main/core/scheduler/scheduler_policy_host_steal.c 82.06% <0.00%> (+0.38%) ⬆️
src/main/host/thread_ptrace.c 66.61% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 931e067...85ecefc. Read the comment docs.

@stevenengler
Copy link
Contributor Author

(This is ready for review, but I'll wait until January before I assign it to anyone.)

Copy link
Member

@robgjansen robgjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty simple version bumps :)

@stevenengler stevenengler merged commit a0538d8 into shadow:dev Dec 21, 2020
@stevenengler stevenengler deleted the upgrade-random branch December 21, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Build Build/install tools and dependencies Priority: Low Prioritized below most other issues Status: Accepted Bug is reproducible or effort is allocated Type: Maintenance Refactoring, cleanup, documenation, or process improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants