Update default config options #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robgjansen
added
Type: Maintenance
Codecov Report
@@ Coverage Diff @@
## dev #1346 +/- ##
=======================================
Coverage 56.60% 56.61%
=======================================
Files 141 141
Lines 20122 20122
Branches 4997 4997
=======================================
+ Hits 11391 11393 +2
Misses 5837 5837
+ Partials 2894 2892 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
We want to enable CPU pinning for improved performance. But when running our tests in parallel, we disable pinning so we don't pin multiple tests to the same CPU core. Closes #1271
stevenengler
approved these changes
May 12, 2021
| /// Use CPU pinning | ||
| /// Pin each thread and any processes it executes to the same CPU to improve cache affinity |
There was a problem hiding this comment.
Maybe use "logical CPU core" to specify that you don't mean the same CPU package?
This was referenced May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1271, and #1297