Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete ptrace #2222

Merged
merged 14 commits into from
Jun 7, 2022
Merged

Delete ptrace #2222

merged 14 commits into from
Jun 7, 2022

Conversation

sporksmith
Copy link
Contributor

@sporksmith sporksmith commented Jun 6, 2022 •
edited

Remove thread_ptrace and associated code.

Fixes #1945, which has more context and motivation. TLDR: we want to delete this and further simplify (#2223) before rewriting in Rust.

@sporksmith sporksmith added this to the Code health and maintenance milestone Jun 6, 2022
@github-actions github-actions bot added Component: Build Build/install tools and dependencies Component: Documentation In-repository documentation, under docs/ Component: Libraries Support functions like LD_PRELOAD and logging Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks labels Jun 6, 2022
@sporksmith sporksmith mentioned this pull request Jun 6, 2022
Closed
@sporksmith sporksmith marked this pull request as ready for review June 6, 2022 19:47
stevenengler
stevenengler approved these changes Jun 7, 2022
View reviewed changes
docs/shadow_config_spec.md Show resolved Hide resolved
src/main/core/support/configuration.rs Outdated Show resolved Hide resolved
src/main/core/support/configuration.rs Outdated Show resolved Hide resolved
sporksmith
sporksmith commented Jun 7, 2022
View reviewed changes
Copy link
Contributor Author

@sporksmith sporksmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tips to clean up the config changes :)

docs/shadow_config_spec.md Show resolved Hide resolved
src/main/core/support/configuration.rs Outdated Show resolved Hide resolved
src/main/core/support/configuration.rs Outdated Show resolved Hide resolved
@sporksmith sporksmith enabled auto-merge June 7, 2022 15:52
@sporksmith sporksmith merged commit 05caf4e into shadow:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenengler stevenengler stevenengler approved these changes

Assignees

@sporksmith sporksmith

Labels
Component: Build Build/install tools and dependencies Component: Documentation In-repository documentation, under docs/ Component: Libraries Support functions like LD_PRELOAD and logging Component: Main Composing the core Shadow executable Component: Testing Unit and integration tests and frameworks
Projects
None yet
Milestone
Code health and maintenance
Development

Successfully merging this pull request may close these issues.

Remove --interpose-method=ptrace
2 participants
@sporksmith @stevenengler