Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More organization changs to the manager / worker pool #2262

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

stevenengler
Copy link
Contributor

These changes are to prepare for the rust migration of the Manager.

  • Workers now add their local counters to the global counters --- Rather than having each worker add its counters to the manager through the global worker pool, each worker now adds its counters to the global counters and the manager then later reads from the global counters.
  • Worker pool now accesses the controller, pid watcher, and config directly --- This is work towards making the controller/manager/scheduler/workerpool more composable and to limit parent references.

@stevenengler stevenengler added Type: Maintenance Refactoring, cleanup, documenation, or process improvements Component: Main Composing the core Shadow executable labels Jul 7, 2022
@stevenengler stevenengler self-assigned this Jul 7, 2022
@stevenengler stevenengler added this to In progress in Release v2.2 via automation Jul 7, 2022
src/main/core/worker.c Outdated Show resolved Hide resolved
src/main/core/worker.rs Show resolved Hide resolved
src/main/core/worker.c Outdated Show resolved Hide resolved
Rather than having each worker add its counters to the manager through the
global worker pool, each worker now adds its counters to the global counters
and the manager then later reads from the global counters.
…ctly

This is work towards making the controller/manager/scheduler/workerpool more
composable and to limit parent references.
@stevenengler stevenengler merged commit 9f931b4 into shadow:main Jul 7, 2022
Release v2.2 automation moved this from In progress to Done Jul 7, 2022
@stevenengler stevenengler deleted the manager-reorg branch July 7, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Main Composing the core Shadow executable Type: Maintenance Refactoring, cleanup, documenation, or process improvements
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants