Refactor token bucket from netiface to a rust module #2306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robgjansen
added
Type: Maintenance
github-actions
bot
added
the
Component: Documentation
robgjansen
modified the milestones:
Convert existing modules to Rust,
Improve modularity of router object
|
Performance benchmark results here: https://github.com/shadow/benchmark-results/tree/master/tor/2022-07-25-T01-38-53 |
robgjansen
force-pushed
the
token-bucket-rs
branch
from
7cf444b
to
e751389
Compare
stevenengler
approved these changes
Aug 1, 2022
robgjansen
force-pushed
the
token-bucket-rs
branch
from
a3e8371
to
6ba00f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in rewriting the network interface and router in rust.
Most of the network interface C code that is changed here will be removed in my upcoming pull requests, so I'm not spending much effort to optimizing the code or it's design at this point.
Progress on #1727